SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,488 Commits 2 Branches 0 Tags
7119b8ebb252ca3775a1be16f446e99b735f5b98
Commit Graph
5488 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Aleksander Morgado 7119b8ebb2 bearer-qmi: new optional connection status monitoring 
This update makes it possible to request connection status polling for
QMI modems via the ID_MM_QMI_CONNECTION_STATUS_POLLING_ENABLE tag.

If not given, the connection status polling will be disabled by
default, and the QMI modem will rely on WDS indications only.
 2017-11-23 14:20:39 +01:00
Aleksander Morgado d20d46a629 iface-modem: remove invalid modem reference count in update_lock_info() 
The modem object is being explicitly referenced and stored in the
Context, but then never unref-ed, completely leaking a modem reference
forever.

Fixes: 4df5458847
 2017-11-23 14:20:38 +01:00
Aleksander Morgado de334b7777 broadband-modem-qmi: plug memleak when listing stored images 
==24602== 288 bytes in 4 blocks are definitely lost in loss record 4,693 of 4,860
==24602==    at 0x4C2CE5F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==24602==    by 0x67292F9: g_malloc (in /usr/lib/libglib-2.0.so.0.5400.0)
==24602==    by 0x670A706: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5400.0)
==24602==    by 0x670B849: g_slice_alloc0 (in /usr/lib/libglib-2.0.so.0.5400.0)
==24602==    by 0x53D3A24: __qmi_message_dms_get_stored_image_info_response_parse (qmi-dms.c:22779)
==24602==    by 0x53E5C61: get_stored_image_info_ready (qmi-dms.c:32287)
==24602==    by 0x6134908: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5400.0)
==24602==    by 0x613499E: ??? (in /usr/lib/libgio-2.0.so.0.5400.0)
==24602==    by 0x67180BD: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5400.0)
==24602==    by 0x6719F68: ??? (in /usr/lib/libglib-2.0.so.0.5400.0)
==24602==    by 0x671AF41: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5400.0)
==24602==    by 0x14477B: main (main.c:180)
 2017-11-23 13:02:42 +01:00
Aleksander Morgado 75933c3e8b po: update Ukrainian translation 
From: Yuri Chornoivan <yurchor@ukr.net>

https://bugs.freedesktop.org/show_bug.cgi?id=103685
 2017-11-12 13:41:29 +01:00
Aleksander Morgado 17b8fcfd77 build: minor build rules reordering for the udev rules tester 
Move it after all plugin build rules.
 2017-11-11 13:39:16 +01:00
Aleksander Morgado 4f0a796ece cli: port mmcli_get_call to GTask 2017-11-03 11:55:04 +01:00
Aleksander Morgado 6f9e2003e0 cli: port mmcli_get_sim to GTask 2017-11-03 11:55:04 +01:00
Aleksander Morgado 050eb46f51 cli: port mmcli_get_sms to GTask 2017-11-03 11:55:03 +01:00
Aleksander Morgado f94a93d66a cli: port mmcli_get_bearer to GTask 2017-11-03 11:55:03 +01:00
Aleksander Morgado 11e9b727b4 cli: port mmcli_get_modem to GTask 2017-11-03 11:55:03 +01:00
Aleksander Morgado 6bf046b6fc cli: port mmcli_get_manager to GTask 2017-11-03 11:55:03 +01:00
Luis A. Lozano 71f0fc6821 sms-cdma-part: fix tautological-constant-compare compiler warning 
This patch fixes the following compiler warning issued by clang:

  mm-sms-part-cdma.c:301:46: mcomparison 'guint8' (aka 'unsigned char') <= 255 is always true
  [-Werror,-Wtautological-constant-compare]
 2017-10-26 09:29:20 +02:00
Eric Caruso 098c4c0271 mm-broadband-modem-qmi: reprobe on qmi-proxy death 
This allows us to reprobe the modem and respawn the
qmi-proxy in case it dies on us. This gets us access
to the modem and unsolicited notifications again. Do
this by connecting to the device-removed signal on
QmiDevice.

---
Rebased on top of git master by
Aleksander Morgado <aleksander@aleksander.es>
 2017-10-22 11:53:32 +02:00
Aleksander Morgado b4278615fc po: add Czech translation 
From: Marek Černocký <marek@manet.cz>

https://bugs.freedesktop.org/show_bug.cgi?id=103390
 2017-10-22 11:35:12 +02:00
Ben Chan 965ff93041 novatel: port load_supported_modes to use GTask 2017-10-22 08:13:42 +02:00
Aleksander Morgado adcce66dd7 broadband-modem-qmi: avoid NULL success return in firmware_load_current 
Instead of assuming that NULL is a valid return, make sure we return
an error instead.

This also makes it sure that if the GTask gets cancelled, the result
we set is always a valid GObject, so that the g_object_unref passed as
GDestroyNotify can be safely called always. Not a big deal anyway, as
the GTask cannot be currently cancelled.
 2017-10-20 17:56:36 +02:00
Aleksander Morgado dbb4597e33 broadband-modem-qmi: avoid NULL success return in firmware_load_list 
Instead of assuming that NULL is a valid return, make sure we return
an error instead.
 2017-10-20 17:56:36 +02:00
Aleksander Morgado 6044118b64 broadband-modem-qmi: make it explicit that the GTask is successful 
When load_supported_storages() doesn't run the parent implementation,
the GTask is always successful. Make it explicit, in case the logic
changes in the future.
 2017-10-20 17:56:29 +02:00
Ben Chan 4e3bf7524d broadband-modem-qmi: port modem_cdma_load_meid to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan f5270ac5ae broadband-modem-qmi: port modem_cdma_load_esn to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan 607dee3a95 broadband-modem-qmi: port modem_3gpp_load_operator_code to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan e365cf531c broadband-modem-qmi: port modem_3gpp_load_operator_name to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan 942a3565e2 broadband-modem-qmi: port modem_3gpp_load_imei to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan be1b3add84 broadband-modem-qmi: port modem_messaging_setup_sms_format to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan 9b27a8bd9a broadband-modem-qmi: port modem_load_supported_ip_families to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan 0b942a6759 broadband-modem-qmi: port modem_load_supported_ip_modes to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan bba2386238 broadband-modem-qmi: port modem_load_device_identifier to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan 55c3e162b1 broadband-modem-qmi: port modem_load_unlock_required to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan 2ba17be8b6 broadband-modem-qmi: port modem_create_bearer to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan 2aaac123ac broadband-modem-qmi: port messaging_load_supported_storages to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan bf9e5cdfeb broadband-modem-qmi: port messaging_check_support to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan 30dfe3055e broadband-modem-qmi: port signal_check_support to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan e9ee49d583 broadband-modem-qmi: port oma_check_support to use GTask 2017-10-20 17:20:24 +02:00
Ben Chan 3e91956d0c broadband-modem-qmi: port location_load_capabilities to use GTask 2017-10-20 17:20:23 +02:00
Ben Chan d99398b055 broadband-modem-qmi: port enable_location_gathering to use GTask 2017-10-20 17:20:23 +02:00
Ben Chan 07d922e250 broadband-modem-qmi: port firmware_load_list to use GTask 2017-10-20 17:20:23 +02:00
Ben Chan af2f87d2f2 broadband-modem-qmi: port firmware_load_current to use GTask 2017-10-20 17:20:23 +02:00
Ben Chan 02fadb6e91 broadband-modem-qmi: port enabling_started to use GTask 2017-10-20 17:20:23 +02:00
Ben Chan b412ddc8b9 broadband-modem-qmi: port initialization_started to use GTask 2017-10-20 17:20:23 +02:00
Ben Chan a20686c24c via: port modem_cdma_{setup,cleanup}_unsolicited_events to use GTask 2017-10-20 09:44:56 +02:00
Ben Chan 47cdad55a8 anydata: port get_detailed_registration_state to use GTask 2017-10-20 09:44:56 +02:00
Aleksander Morgado 689dad9f6e base-bearer: fix reporting tx/rx stats 
The numbers were actually swapped!
 2017-10-19 11:43:50 +02:00
Aleksander Morgado 25007741c8 mmcli,sim: force sync operation for the info action 2017-10-18 23:05:18 +02:00
Aleksander Morgado fc40c059fa broadband-modem-mbim: plug memleak when querying previous unlock retries 
==15673== 240 (40 direct, 200 indirect) bytes in 1 blocks are definitely lost in loss record 4,341 of 4,535
    ==15673==    at 0x647F014: g_type_create_instance (in /usr/lib/libgobject-2.0.so.0.5200.3)
    ==15673==    by 0x6460027: ??? (in /usr/lib/libgobject-2.0.so.0.5200.3)
    ==15673==    by 0x6461A54: g_object_newv (in /usr/lib/libgobject-2.0.so.0.5200.3)
    ==15673==    by 0x6462213: g_object_new (in /usr/lib/libgobject-2.0.so.0.5200.3)
    ==15673==    by 0x4E97C33: mm_unlock_retries_new (mm-unlock-retries.c:217)
    ==15673==    by 0x4E97A6F: mm_unlock_retries_new_from_dictionary (mm-unlock-retries.c:171)
    ==15673==    by 0x170B09: mm_iface_modem_get_unlock_retries (mm-iface-modem.c:2942)
    ==15673==    by 0x1DB0A4: pin_query_unlock_retries_ready (mm-broadband-modem-mbim.c:782)
    ==15673==    by 0x613AD52: ??? (in /usr/lib/libgio-2.0.so.0.5200.3)
    ==15673==    by 0x613B775: ??? (in /usr/lib/libgio-2.0.so.0.5200.3)
    ==15673==    by 0x57D525D: transaction_task_complete_and_free (mbim-device.c:246)
    ==15673==    by 0x57D6086: process_message (mbim-device.c:666)
 2017-10-08 10:27:12 +02:00
Aleksander Morgado 58e6f652a1 base-modem: plug memleaks when building port lists 
The mm_base_modem_find_ports() method builds a list of full
references, so we need to unref them in the peek() methods.

    ==10047== 14,959 (24 direct, 14,935 indirect) bytes in 1 blocks are definitely lost in loss record 5,470 of 5,473
    ==10047==    at 0x4C2CE5F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==10047==    by 0x66E3028: g_malloc (in /usr/lib/libglib-2.0.so.0.5200.3)
    ==10047==    by 0x66FAB25: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5200.3)
    ==10047==    by 0x66D9A33: g_list_append (in /usr/lib/libglib-2.0.so.0.5200.3)
    ==10047==    by 0x15F6A7: mm_base_modem_find_ports (mm-base-modem.c:845)
    ==10047==    by 0x15E9F3: mm_base_modem_peek_port_qmi_for_data (mm-base-modem.c:579)
    ==10047==    by 0x15E8FC: mm_base_modem_get_port_qmi_for_data (mm-base-modem.c:555)
    ==10047==    by 0x1BB99F: _connect (mm-bearer-qmi.c:1391)
    ==10047==    by 0x1540B4: mm_base_bearer_connect (mm-base-bearer.c:841)
    ==10047==    by 0x181F4F: connection_step (mm-iface-modem-simple.c:597)
    ==10047==    by 0x181321: create_bearer_ready (mm-iface-modem-simple.c:258)
    ==10047==    by 0x612FD52: ??? (in /usr/lib/libgio-2.0.so.0.5200.3)
 2017-10-07 14:10:12 +02:00
Aleksander Morgado 882f6b04d6 cinterion: port modem_create_bearer to GTask 2017-10-07 14:10:12 +02:00
Aleksander Morgado e9f56ddf15 cinterion: port after_sim_unlock to GTask 2017-10-07 13:58:55 +02:00
Aleksander Morgado b1948f83a5 cinterion: port load_unlock_retries_context to GTask 2017-10-07 13:40:30 +02:00
Aleksander Morgado e1b2b88e68 cinterion: port setup_flow_control to GTask 2017-10-07 13:40:30 +02:00
Aleksander Morgado 926e0176fb cinterion: port set_current_bands to GTask 2017-10-07 13:40:30 +02:00