Dan Williams
263be58465
There was a race where if PPP was slow to start, MM could read the first bits of PPP from the port, which MM shouldn't really do. So if the port is connected, remove our GIOChannel watch and let pppd handle all the data. When the port is disconnected, re-attach our watch and start reading from the port again. This may make it harder to detect spurious disconnects if for example pppd drops the connection and the thing controlling PPP (eg, NetworkManager or something else) doesn't tell us about that event by disconnecting the bearer. This is arguably programmer error though. See the logs in https://bugzilla.gnome.org/show_bug.cgi?id=624956#c10 for an example of this: DEBUG: <1280300196.929489> (ttyACM0): <-- '<CR><LF>CONNECT<CR><LF>' DEBUG: <1280300196.929761> (ttyACM0): port now connected DEBUG: <1280300196.929853> Modem /org/freedesktop/ModemManager/Modems/0: state changed (connecting -> connected) DEBUG: <1280300196.929954> (ttyACM0): simple connect state 6 DEBUG: <1280300196.933432> (ttyACM0): <-- '~\-1}#\-64!}!} } }2}#}$\-64#}!}$}%\-36}"}&} }*} } g}%~'
ModemManager. The problem ModemManager tries to solve is to provide a unified high level API for communicating with (mobile broadband) modems. While the basic commands are standardized, the more advanced operations (like signal quality monitoring while connected) varies a lot. Using. ModemManager is a system daemon and is not meant to be used directly from the command line. However, since it provides DBus API, it is possible to use 'dbus-send' command to control it from the terminal. There's an example program (tests/mm-test.py) that demonstrates the basic API usage. Implementation. ModemManager is a DBus system bus activated service (meaning it's started automatically when a request arrives). It is written in C. The devices are queried from udev and automatically updated based on hardware events. There's a GInterface (MMModem) that defines the modem interface and any device specific implementation must implement it. There are two generic MMModem implementations to support the basic operations (one for GSM, one for CDMA,) which are common for all cards. Plugins. Plugins are loaded on startup, and must implement the MMPlugin interface. It consists of a couple of methods which tell the daemon whether the plugin supports a port and to create custom MMModem implementations. It most likely makes sense to derive custom modem implementations from one of the generic classes and just add (or override) operations which are not standard. There's a fully working plugin in the plugins/ directory for Huawei cards that can be used as an example for writing new plugins. Writing new plugins is highly encouraged! API. The API is open for changes, so if you're writing a plugin and need to add or change some public method, feel free to suggest it!