701 Commits
Author SHA1 Message Date
Guido Günther 4551b1c939 fbd-feedback-led: Modernize property definitions
Adapt current phosh coding style before making other changes
2024-06-13 07:44:42 +02:00
Guido Günther 8d4c2590cb doc: Fix URLs
Don't use Markdown markup as it looks odd in the generated page.
2024-06-13 07:44:39 +02:00
Guido Günther 17d910651d doc: Document feedback types
This allows us to remove the list from the README
2024-06-13 07:44:36 +02:00
Guido Günther 6e9e5700c0 dev-led-multicolor: Use correct format specifier
The values are unsigned int
2024-06-13 07:44:34 +02:00
Guido Günther 9aa6696eb8 build: Let daemon dependency depend on generated enum headers
Otherwise it might not be available in the tests
2024-06-13 07:44:25 +02:00
Guido Günther a0a0c46a26 Merge branch 'ci' into 'main'
Use shared ci from meta-phosh

See merge request Librem5/feedbackd!127
2024-06-13 05:34:39 +00:00
Guido Günther 1c51eb20ec ci: Use common jobs from meta-phosh 2024-06-12 16:24:33 +02:00
Guido Günther e9743f3daa ci: Update common files from meta-phosh
This updates to commit f3c92e90dcc0d65322888217429b75dd101bd0d3
2024-06-12 16:24:33 +02:00
Guido Günther c3b4877dfe Merge branch 'qcom-lpg' into 'main'
led-qcom: Check for LED driver

Closes #77

See merge request Librem5/feedbackd!124
2024-06-11 07:48:49 +00:00
Guido Günther 3c588fdb8f led-qcom: Check for LED driver
The hw_pattern attribute is driver specific. Ensure we don't apply the
LED pattern to unknown drivers.

Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/77
2024-06-10 15:50:50 +02:00
Guido Günther f581c15842 led-qcom-multicolor: Don't leak qcom_led 2024-06-10 10:33:05 +02:00
Guido Günther 255856822a led-qcom-multicolor: Drop unused defines 2024-06-10 10:33:03 +02:00
Guido Günther fcd210ef22 led-qcom: Use char instead of gchar
We prefer the C types in new code.
2024-06-10 10:33:03 +02:00
Guido Günther 12be49b9fc Merge branch 'qcom-lpg-hwpattern' into 'main'
fb-dev-leds: support hw_pattern for Qualcomm LPG

See merge request Librem5/feedbackd!100
2024-06-09 09:45:20 +00:00
Dylan Van Assche 6b1eb92b7a fbd-dev-leds: Probe QCOM HW LED types
Try first the QCOM hardware LED types which require the most features of
LED drivers. Try until we have a single color GPIO LED which is the
minimal LED driver support we require. If the LED does not meet that
expectation either, we ignore the LED.
2024-06-09 11:21:20 +02:00
Dylan Van Assche 2b53725fcb fbd-dev-led-qcom-multicolor: Support QCOM LPG LED multicolor
QCOM LPG LEDs can also operate in a multicolor fashion.
Re-use the probing sequence of multicolor LEDs and the hw_pattern
configuration of single color QCOM LPG LEDs.
2024-06-09 11:21:20 +02:00
Dylan Van Assche 10e6d3cba8 fbd-dev-led-qcom: Support QCOM LPG LED single color
QCOM LPG LEDs expose a hw_pattern sysfs entry which accepts a limited
set of patterns but allows to use dedicated hardware for blinking the
LED. This way, battery life can be improved and the LED still blinks,
even if the device is suspended.
2024-06-09 11:21:20 +02:00
Dylan Van Assche 22e4c33606 fbd-dev-led-multicolor: Support red, green, blue and white LED colors
Provide our own supports_color method to specify which colors are
actually implemented by the driver. RGB LEDs could provide different
colors as well such as orange, purple, etc. but those are not supported
yet.
2024-06-09 11:21:20 +02:00
Dylan Van Assche 60ce9ecb3c fbd-dev-led: Check max_brightness_percentage range
Percentages are always between 0.0 and 100.0.
Also fix a typo along the way.
2024-06-09 11:21:20 +02:00
Dylan Van Assche 63b564494b fbd-ledctrl: Set permissions for hw_pattern
Allow access to hw_pattern sysfs node for feedbackd, similar to other nodes.
2024-06-09 11:21:20 +02:00
Dylan Van Assche e43126b007 fbd-dev-led: Rework color API
Drop has_color API since supported colors are set during probing
and can be handled completely separately from the classes for
each type of hardware.

Rename set_color to set_supported_color because the usage
of this API is to check if the color is supported, but not
setting it. Setting the color is also separated from
start_periodic API to re-use multicolor across multiple LED types
with a set_color API. Multicolor LEDs are actually the same as
regular LEDs but they require a few additional sysfs entries to
actually set the color. Single color LEDs only have a single color
so the set_color method just returns TRUE for these LEDs.

Supported colors are advertised through the supports_color API now.
This way, each LED driver define which colors are supported
through supports_color API. RGB multicolor LEDs will report only fixed colors
like red, blue, green and white until the kernel can expose if a diffusor
is present to mix these colors.
2024-06-09 11:21:19 +02:00
Dylan Van Assche bcd37b0aa5 fbd-dev-led-*: Adjust to method convention
fbd_dev_led_ is the convention for methods, adjust them all.
2024-06-09 11:18:09 +02:00
Dylan Van Assche 94afe719a9 fbd-dev-led: Scan for RGB color as well
Multicolor LEDs have the color 'rgb', we should also scan it
as they are also a FbdDevLed.
2024-06-07 10:15:39 +02:00
Dylan Van Assche 7f69813e84 fbd-dev-led-multicolor: Fix typo in error message
multicololo -> multicolor LED
2024-06-07 10:15:30 +02:00
Dylan Van Assche 66b616677d fbd-dev-led-multicolor: Use separate log domain
Debugging driver probing is much easier when each driver has its own log domain.
2024-06-07 10:14:45 +02:00
Guido Günther d4d1796c05 Merge branch 'doc-fix' into 'main'
lfb-event: Fix typo in docstring

See merge request Librem5/feedbackd!123
2024-05-31 13:17:25 +00:00
Guido Günther bc0449f79d lfb-event: Fix typo in docstring
Gbp-Dch: Ignore
2024-05-31 15:01:00 +02:00
Guido Günther cfa8e0b2da Merge branch 'umockdev' into 'main'
tests: Add umockdev based tests for leds

See merge request Librem5/feedbackd!122
2024-05-17 06:41:51 +00:00
Guido Günther d5b0f30205 tests: Add umockdev based tests for leds
This ensures we can probe the different led types correctly

The umockdev data was recoreded on an Librem 5 and Librem 14
2024-05-17 06:24:50 +00:00
Guido Günther 2db8e8f820 ci: Add clang build 2024-05-17 06:24:50 +00:00
Guido Günther a188cdde7c Build: Use meson instead of ninja 2024-05-17 06:24:50 +00:00
Guido Günther f6a92231db fbd-theme-validate: Use G_NORETURN 2024-05-17 06:24:50 +00:00
Guido Günther 95c51c021d fbd-dev-led-multicolor: Drop unused variable 2024-05-17 06:24:50 +00:00
Guido Günther 973c7e006e led: Don't forget to init variable 2024-05-17 06:24:50 +00:00
Guido Günther b8718992d1 led: Drop unused variable 2024-05-17 06:24:50 +00:00
Guido Günther 83f14a451a led: Add doc strings 2024-05-17 06:24:50 +00:00
Guido Günther eccd95a1e6 Merge branch 'docs' into 'main'
docs: Expand the examples section a bit

See merge request Librem5/feedbackd!121
2024-05-11 12:12:14 +00:00
Guido Günther 945435f0b5 docs: Expand the examples section a bit 2024-05-11 13:59:55 +02:00
Guido Günther bf6928e47d Merge branch 'rel-0.3.0' into 'main'
Document changes and release 0.3.0

See merge request Librem5/feedbackd!120
2024-04-21 11:16:53 +00:00
Guido Günther ec6e86ee0c Document changes and release 0.3.0 2024-04-21 12:20:58 +02:00
Guido Günther ea98669bb9 Merge branch 'important-hint' into 'main'
Add `important` hint

See merge request Librem5/feedbackd!116
2024-04-20 13:32:37 +00:00
Guido Günther 2d1d72c746 feedback-manager: Handle important hint
This allows blessed apps to override the per-app as well as the global
feedback level. This can e.g. be useful for alarm clocks.
2024-04-20 13:21:56 +00:00
Guido Günther f575d32651 cli: Allow to set important hint 2024-04-20 13:21:56 +00:00
Guido Günther 716f296ab8 feedback-manager: Parse important hint 2024-04-20 13:21:56 +00:00
Guido Günther 14ffd9722d libfeedback: Allow to set important hint 2024-04-20 13:21:56 +00:00
Guido Günther e6845a52d3 feedback-manager: Use MIN()
A bit easier to read
2024-04-20 13:21:56 +00:00
Guido Günther 6a5d558a83 fbcli: Allow to override app-id
Useful for testing
2024-04-20 13:21:56 +00:00
Guido Günther 7640a73e82 data/schema: Add 'allow-override' gsetting
This allows to list apps that can override the currently
effective feedback level by setting the 'impotant' hint in
the event.
2024-04-20 13:21:56 +00:00
Guido Günther f71ece5d8b data/dbus: Document important hint
The important hint can be used by apps to override the current per app
or system wide feedback level (if the feedback server allows it).
2024-04-20 13:21:56 +00:00
Guido Günther 106663e41c data/dbus: Document current flags 2024-04-20 13:21:56 +00:00