Commit Graph
545 Commits
Author SHA1 Message Date
Guido Günther f0bac054c9 Merge branch 'lint' into 'main'
ci: Add rules for format-check

See merge request Librem5/feedbackd!118
2024-04-15 09:57:14 +00:00
Guido Günther e656775409 Draft: ci: Add rules for format-check 2024-04-15 09:46:44 +00:00
Guido Günther 2a55cdb499 Merge branch 'multicolor-derivable' into 'main'
fbd-dev-led-multicolor: Make it a derivable type

See merge request Librem5/feedbackd!107
2024-04-09 16:10:06 +00:00
Guido Günther 0dbbc93adc fbd-dev-led-multicolor: Make it a derivable type
This will allow hw-pattern classes to derive from it.
2024-04-09 15:43:03 +00:00
Guido Günther aa96b064b1 fbd-dev-led-multicolor: Drop unused variable 2024-04-09 15:43:03 +00:00
Guido Günther 987e6371f9 fbd-dev-led-multicolor: Fix indentation 2024-04-09 15:43:03 +00:00
Guido Gunther 7588ecab91 Merge branch 'uncrustify' into 'main'
Update deps and add style check

See merge request Librem5/feedbackd!115
2023-11-18 12:15:57 +00:00
Guido Günther 8020ccc65c ci: Run style checks on merge requests 2023-11-14 17:26:07 +01:00
Guido Günther ba4576d490 ci: Add uncrustify config and checker
Based on what we added to phoc recently
2023-11-14 17:26:07 +01:00
Guido Günther 6c9cadc009 ci: Switch to trixie 2023-11-14 17:26:07 +01:00
Guido Günther d83397279f build: Switch gmobile to 0.0.4
We switch to a wrap which helps us to avoid the submodule
2023-11-14 17:26:07 +01:00
Guido Günther fea20a73d4 packaging: Use meson's default wrap mode
ci should be allowed to download gmobile
2023-11-14 17:26:07 +01:00
Guido Gunther 853bd6d7ea Merge branch 'docs' into 'main'
feedback-themes: Improve wording

See merge request Librem5/feedbackd!114
2023-09-06 14:23:09 +00:00
Guido Günther 3b970ef34b debian: Install NEWS 2023-09-01 13:06:08 +02:00
Guido Günther 708abf1e4a debian: Fix nodoc build
Don't try to install the dev docs in that case.
2023-09-01 13:06:08 +02:00
Guido Günther b20f08c030 debian: Update from the current packaging in Debian
- Validate fbd-theme-validate
- Add Build-dep to symbols file
- Add doc-base registration
- Use dh_installman to fix nodoc build
- Update debian/copyright
- Improve Recommends: and multi arch annotations
- Add lintian overrides
2023-09-01 13:06:08 +02:00
Guido Günther 48b5ca547f manpages: Fix whatis entry 2023-09-01 13:06:08 +02:00
Guido Günther 93dab70f24 manpages: Improve references 2023-09-01 13:00:49 +02:00
Guido Günther b96a25394b feedback-themes: Improve wording 2023-09-01 13:00:49 +02:00
Guido Günther 5f9d576de8 gitignore gir package 2023-09-01 13:00:48 +02:00
Guido Günther 7521e5b5db NEWS: Add missing contributors for 0.2.1 2023-09-01 13:00:47 +02:00
Guido Gunther 1104cef50a Merge branch 'rel-0.2.1' into 'main'
Document changes and release 0.2.1

See merge request Librem5/feedbackd!113
2023-08-31 09:51:38 +00:00
Guido Günther 9316426225 Document changes and release 0.2.1 2023-08-29 18:32:34 +02:00
Guido Gunther 6a1582f400 Merge branch 'manpage' into 'main'
Add manpage for feedback themes

See merge request Librem5/feedbackd!112
2023-08-29 16:30:47 +00:00
Guido Günther 154701fee6 doc: Add manpage for feedback themes
This should direct users to the documentation.

Prompted by https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050762
2023-08-29 12:19:54 +02:00
Guido Günther 2ca7a329b7 doc: Better cross reference manpages 2023-08-29 12:14:11 +02:00
Guido Günther 65fa915184 treewide: Drop superfluous '()' after functions in doc strings
Otherwise we have that doubled in the docs
2023-08-29 12:14:11 +02:00
Guido Günther fd28bfd78e event: Fix doc link 2023-08-29 12:14:11 +02:00
Guido Günther b3758dee3d Update NEWS 2023-04-24 10:54:44 +02:00
Guido Gunther eadcfb16c3 Merge branch 'app-id-set' into 'main'
Add API to set app_id

See merge request Librem5/feedbackd!111
2023-04-24 08:41:45 +00:00
Guido Günther 8d4b1a09ab Document changes and release 0.2.0 2023-04-17 13:33:08 +02:00
Guido Günther 08ee0daa12 debian/symbols: Update with new API 2023-04-17 13:32:21 +02:00
Guido Günther f9aae0b689 build: Bump version to 0.2.0
We have a slight api change
2023-04-17 13:32:21 +02:00
Guido Günther 2de190fb09 lfb-event: Add getter and setter for app-id
For applications this is figured out automatically but notification
daemons and portal implementations might want to override it to have the
per-app feedback profile picked up automatically.
2023-04-17 13:32:21 +02:00
Guido Günther a58b47e1eb tests: Get properties all at once 2023-04-17 12:21:06 +02:00
Guido Günther 1a5cd090de lfb-event: Avoid allocation when getting profile
We can return the const *. This makes it consistent with other getters.

This is an API change we didn't find any users and the API is declared
unstable.
2023-04-17 12:21:06 +02:00
Guido Günther 31a592e18e debian/symbols: Bump all symbol dependencies to 0.1.1
We want to make sure apps run against a recent version even on
partial upgrades.
2023-04-17 12:21:06 +02:00
Guido Gunther ce10466203 Merge branch 'rel-0.1.1' into 'main'
Document changes and release 0.1.1

See merge request Librem5/feedbackd!110
2023-03-29 15:31:48 +00:00
Guido Günther 40e1c58de1 Document changes and release 0.1.1 2023-03-23 10:38:30 +01:00
Guido Gunther 1dbad7e536 Merge branch 'fixes' into 'main'
Fix crash exposed by glib 2.76

Closes #69

See merge request Librem5/feedbackd!109
2023-03-17 16:47:22 +00:00
Guido Günther f9c65381db tests/profile: Don't leak json node 2023-03-13 15:26:20 +01:00
Guido Günther 3d7c4b376a feedback-theme: Don't leak parent name 2023-03-13 15:26:18 +01:00
Guido Günther 7becab3346 feedback-theme: Don't leak json array when serializing profile
json_array_add_element doesn't transfer ownership.
2023-03-13 15:26:15 +01:00
Guido Günther 5206c3aae5 feedback-profile: Don't leak json array when serializing profile
json_array_add_element doesn't transfer ownership
2023-03-13 15:26:10 +01:00
Guido Günther 1933a23172 tests: Don't leak profiles and test that
We finalize the theme first so the last reference is dropped when
finalizing the profiles.
2023-03-13 15:26:07 +01:00
Guido Günther 460985cfa0 tests: Don't leak json string 2023-03-13 15:26:04 +01:00
Guido Günther 03b0f4c2aa fbd-event: Make sure we iterate the list safely
When all feedbacks are done the event signals "feedbacks-ended" which
lets the manager dispose the feedback. When all feedbacks end instantly
and synchronously (as is the case with the dummy feedback) this triggers
the disposal of the event within the loop leading to a crash.

Make sure the object doesn't go away be referencing it during the loop
iteration.

We didn't see this before as glib's slice allocator for lists papered
over this for us.

Closes: https://source.puri.sm/Librem5/feedbackd/-/issues/69
2023-03-13 15:25:41 +01:00
Guido Günther 64076e5ad0 fbd-event: Simplify
Gbp-Dch: Ignore
2023-03-13 15:25:37 +01:00
Guido Günther 847c21d78e build: Avoid meson deprecation warning 2023-03-13 15:25:31 +01:00
Guido Gunther 2db8a72ef9 Merge branch 'rel-0.1.0' into 'main'
Release 0.1.0

See merge request Librem5/feedbackd!108
2023-02-27 16:20:02 +00:00