SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

network/vxlan: avoid unneccesary temporary variables

Browse Source 
parse_ip_port_range() DTRT and only sets the output on success.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek
2023-09-22 08:17:42 +02:00
parent 257cebb67a
commit 04c2a002e6
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/network/netdev/vxlan.c
+5 -12
View File
@@ -286,25 +286,18 @@ int config_parse_port_range(
void *data,
void *userdata) {
VxLan *v = userdata;
uint16_t low, high;
int r;
assert(filename);
assert(lvalue);
assert(rvalue);
assert(data);
r = parse_ip_port_range(rvalue, &low, &high);
if (r < 0) {
VxLan *v = ASSERT_PTR(userdata);
int r;
r = parse_ip_port_range(rvalue, &v->port_range.low, &v->port_range.high);
if (r < 0)
log_syntax(unit, LOG_WARNING, filename, line, r,
"Failed to parse VXLAN port range '%s'. Port should be greater than 0 and less than 65535.", rvalue);
return 0;
}
v->port_range.low = low;
v->port_range.high = high;
return 0;
}