Merge pull request #2350 from evverx/fix-memory-leak-on-failed-preset-all

core: fix memory leak on failed preset-all
2016-01-18 10:52:15 +01:00
parent e1333db540 c292c3af38
commit 0cdf4f210c
1 changed files with 3 additions and 1 deletions
@@ -1844,8 +1844,10 @@ static int method_preset_all_unit_files(sd_bus_message *message, void *userdata,
        scope = m->running_as == MANAGER_SYSTEM ? UNIT_FILE_SYSTEM : UNIT_FILE_USER;

        r = unit_file_preset_all(scope, runtime, NULL, mm, force, &changes, &n_changes);
-        if (r < 0)
+        if (r < 0) {
+                unit_file_changes_free(changes, n_changes);
                return r;
+        }

        return reply_unit_file_changes_and_free(m, message, -1, changes, n_changes);
 }