SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

network: the maximum MTU size for CAN interface may be changed later

Browse Source 
So we should not reduce the requested size to the current maximum
before applying CAN FD mode.
This commit is contained in:
Yu Watanabe
2023-12-08 10:47:42 +09:00
parent a60cc587d4
commit 15be804282
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/network/networkd-setlink.c
+13 -4
View File
@@ -866,7 +866,7 @@ int link_request_to_set_master(Link *link) {
int link_request_to_set_mtu(Link *link, uint32_t mtu) {
const char *origin;
uint32_t min_mtu;
uint32_t min_mtu, max_mtu;
Request *req;
int r;
@@ -894,10 +894,19 @@ int link_request_to_set_mtu(Link *link, uint32_t mtu) {
mtu = min_mtu;
}
if (mtu > link->max_mtu) {
max_mtu = link->max_mtu;
if (link->iftype == ARPHRD_CAN)
/* The maximum MTU may be changed when FD mode is changed.
* See https://docs.kernel.org/networking/can.html#can-fd-flexible-data-rate-driver-support
* MTU = 16 (CAN_MTU) => Classical CAN device
* MTU = 72 (CANFD_MTU) => CAN FD capable device
* So, even if the current maximum is 16, we should not reduce the requested value now. */
max_mtu = MAX(max_mtu, 72u);
if (mtu > max_mtu) {
log_link_warning(link, "Reducing the requested MTU %"PRIu32" to the interface's maximum MTU %"PRIu32".",
mtu, link->max_mtu);
mtu = link->max_mtu;
mtu, max_mtu);
mtu = max_mtu;
}
if (link->mtu == mtu)