SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

resolved: simplify min_ttl check

Browse Source 
rr is asserted upon a few lines above, no need to check for null.
Coverity-found issue, CID 1450844

  CID 1450844:  Null pointer dereferences  (REVERSE_INULL)
  Null-checking "rr" suggests that it may be null, but it has already
    been dereferenced on all paths leading to the check.
This commit is contained in:
Luca Boccassi
2021-03-17 18:56:33 +00:00
committed by Luca Boccassi
parent 04820600e7
commit 18da936481
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/resolve/resolved-dns-cache.c
+1 -3
View File
@@ -439,9 +439,7 @@ static int dns_cache_put_positive(
/* Determine the minimal TTL of all RRs in the answer plus the one by the main RR we are supposed to
* cache. Since we cache whole answers to questions we should never return answers where only some
* RRs are still valid, hence find the lowest here */
min_ttl = dns_answer_min_ttl(answer);
if (rr)
min_ttl = MIN(min_ttl, rr->ttl);
min_ttl = MIN(dns_answer_min_ttl(answer), rr->ttl);
/* New TTL is 0? Delete this specific entry... */
if (min_ttl <= 0) {