SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

network/wwan: add missing error check

Browse Source 
Fixes CID#1645015.
This commit is contained in:
Yu Watanabe
2026-02-17 17:01:00 +09:00
parent 2e8cfb7cef
commit 1a416a47e7
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/network/networkd-wwan-bus.c
+10 -6
View File
@@ -477,18 +477,16 @@ static int bearer_new_and_initialize(Modem *modem, const char *path) {
static int modem_connect_handler(sd_bus_message *message, void *userdata, sd_bus_error *ret_error) {
Modem *modem = ASSERT_PTR(userdata);
const sd_bus_error *e;
const char *new_bearer;
int r;
assert(message);
modem->slot_connect = sd_bus_slot_unref(modem->slot_connect);
e = sd_bus_message_get_error(message);
const sd_bus_error *e = sd_bus_message_get_error(message);
if (e) {
r = sd_bus_error_get_errno(e);
log_full_errno(LOG_ERR, r,
log_error_errno(r,
"Could not connect modem %s %s: %s",
modem->manufacturer, modem->model,
bus_error_message(e, r));
@@ -497,10 +495,16 @@ static int modem_connect_handler(sd_bus_message *message, void *userdata, sd_bus
return 0;
}
sd_bus_message_read(message, "o", &new_bearer);
const char *new_bearer;
r = sd_bus_message_read(message, "o", &new_bearer);
if (r < 0) {
log_debug_errno(r, "Received connection of %s %s from ModemManager, but bearer not found, ignoring: %m",
modem->manufacturer, modem->model);
return 0;
}
log_debug("ModemManager: %s %s connected, bearer is at %s",
modem->manufacturer, modem->model, new_bearer);
return 0;
}