SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

core/unit: remove unneeded comparison for hashmap_remove_value

Browse Source 
hashmap_remove_value returns NULL if the value in the hashmap doesn't
match with the one provided by the caller.
This commit is contained in:
Mike Yuan
2023-11-11 17:21:10 +08:00
parent 4c8d5f0217
commit 1c2beeb04f
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/unit.c
+2 -2
View File
@@ -2944,7 +2944,7 @@ void unit_unwatch_pidref(Unit *u, PidRef *pid) {
if (uu == u)
/* OK, we are in the first table. Let's remove it there then, and we are done already. */
assert_se(hashmap_remove_value(u->manager->watch_pids, pid2, uu) == uu);
assert_se(hashmap_remove_value(u->manager->watch_pids, pid2, uu));
else {
/* We weren't in the first table, then let's consult the 2nd table that points to an array */
PidRef *pid3 = NULL;
@@ -2962,7 +2962,7 @@ void unit_unwatch_pidref(Unit *u, PidRef *pid) {
if (m == 0) {
/* The array is now empty, remove the entire entry */
assert_se(hashmap_remove_value(u->manager->watch_pids_more, pid3, array) == array);
assert_se(hashmap_remove_value(u->manager->watch_pids_more, pid3, array));
free(array);
} else {
/* The array is not empty, but let's make sure the entry is not keyed by the PidRef