SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vmspawn-varlink: simplify on_qmp_describe_complete result extraction

Browse Source 
Lift the running/status extraction out of the inline ternaries inside
SD_JSON_BUILD_PAIR_*() into named local variables with explicit defaults.
Pure readability change.

Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
This commit is contained in:
Christian Brauner
2026-04-24 14:39:25 +02:00
parent b34413db8e
commit 34d1219763
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vmspawn/vmspawn-varlink.c
+9 -4
View File
@@ -123,13 +123,18 @@ static int on_qmp_describe_complete(
return 0;
}
sd_json_variant *running = sd_json_variant_by_key(result, "running");
sd_json_variant *status = sd_json_variant_by_key(result, "status");
sd_json_variant *running_v = sd_json_variant_by_key(result, "running");
sd_json_variant *status_v = sd_json_variant_by_key(result, "status");
bool running = running_v ? sd_json_variant_boolean(running_v) : false;
const char *status = status_v && sd_json_variant_is_string(status_v) ?
sd_json_variant_string(status_v) : "unknown";
(void) sd_varlink_replybo(
link,
SD_JSON_BUILD_PAIR_BOOLEAN("running", running ? sd_json_variant_boolean(running) : false),
SD_JSON_BUILD_PAIR_STRING("status", status && sd_json_variant_is_string(status) ? sd_json_variant_string(status) : "unknown"));
SD_JSON_BUILD_PAIR_BOOLEAN("running", running),
SD_JSON_BUILD_PAIR_STRING("status", status));
return 0;
}