test: several fixlets for cleanup functions

- if 'set +e' is called in a trap (except for EXIT), then call
  'set -e' at the end.
- added several missing cleanups.

(cherry picked from commit a7de35462a3df6a30e7eba2d36d1b8bd2fd92aaf)
This commit is contained in:
Yu Watanabe
2026-10-16 17:24:51 +01:00
committed by Luca Boccassi
parent aa1ca34586
commit 365cb58058
6 changed files with 24 additions and 8 deletions
@@ -188,7 +188,9 @@ file_write_cleanup() {
# Remove all the mounts and directories we created
# These variables reset to empty arrays when the subprocess concludes.
umount "${CLEANUP_MOUNTS[@]}"
rm -rf "${CLEANUP_PATHS[@]}"
rm -rf --one-file-system "${CLEANUP_PATHS[@]}"
set -e
}
run_testcases
@@ -8,6 +8,7 @@ set -o pipefail
at_exit() {
set +e
systemctl stop tmp-aaa.mount
rm -fr /run/hoge /tmp/aaa
}
+6 -2
View File
@@ -423,7 +423,7 @@ EOF
}
teardown_timesyncd_resolve() {
set +eu
set +e
systemctl start systemd-resolved-varlink.socket
systemctl start systemd-resolved.service
@@ -431,6 +431,8 @@ teardown_timesyncd_resolve() {
rm -rf /run/systemd/system/systemd-timesyncd.service.d
systemctl daemon-reload
systemctl stop systemd-timesyncd
set -e
}
testcase_timesyncd_resolve() {
@@ -481,12 +483,14 @@ EOF
}
teardown_timedated_alternate_paths() {
set +eu
set +e
rm -rf /run/systemd/system/systemd-timedated.service.d
rm -rf /run/alternate-path
systemctl daemon-reload
systemctl restart systemd-timedated
set -e
}
testcase_timedated_alternate_paths() {
+4 -1
View File
@@ -321,9 +321,10 @@ testcase_wildcard_words() {
}
teardown_hostnamed_alternate_paths() {
set +eu
set +e
rm -rf /run/systemd/system/systemd-hostnamed.service.d
rm -rf /run/alternate-path
systemctl daemon-reload
systemctl restart systemd-hostnamed
if [[ -f /etc/hostname ]]; then
@@ -332,6 +333,8 @@ teardown_hostnamed_alternate_paths() {
hostnamectl hostname "${orig}"
fi
fi
set -e
}
testcase_hostnamed_alternate_paths() {
+4 -1
View File
@@ -652,11 +652,14 @@ testcase_locale_gen_leading_space() {
}
teardown_localed_alternate_paths() {
set +eu
set +e
rm -rf /run/systemd/system/systemd-localed.service.d
rm -rf /run/alternate-path
systemctl daemon-reload
systemctl restart systemd-localed
set -e
}
testcase_localed_alternate_paths() {
@@ -54,7 +54,12 @@ cleanup() {
systemd-dissect --detach "$LOOPDEV"
LOOPDEV=""
fi
rm -rf "$WORKDIR"
if [[ -n "${WORKDIR:-}" ]]; then
rm -rf "$WORKDIR"
WORKDIR=""
fi
set -e
}
create_fake_os_source_tree() {
@@ -199,8 +204,6 @@ testcase_sysinstall_basic() {
"$WORKDIR/target.img"
validate_image
cleanup
}
testcase_sysinstall_varlink_basic() {