dns-configuration: dispatch scopes to DNSConfiguration

This is one of several commits to dispatch all fields of the
DNSConfiguration JSON.

Introduce a DNSScope type, and all required JSON dispatching helpers.
This commit is contained in:
Nick Rosbrook
2026-02-03 15:07:41 -05:00
parent e90180f50c
commit 3afb9c20b6
2 changed files with 84 additions and 1 deletions
+71 -1
View File
@@ -151,6 +151,75 @@ static int dispatch_search_domain_array(const char *name, sd_json_variant *varia
return 0;
}
DNSScope* dns_scope_free(DNSScope *s) {
if (!s)
return NULL;
free(s->ifname);
free(s->protocol);
free(s->dnssec_mode_str);
free(s->dns_over_tls_mode_str);
return mfree(s);
}
DEFINE_PRIVATE_HASH_OPS_WITH_VALUE_DESTRUCTOR(
dns_scope_hash_ops,
void,
trivial_hash_func,
trivial_compare_func,
DNSScope,
dns_scope_free);
static int dispatch_dns_scope(const char *name, sd_json_variant *variant, sd_json_dispatch_flags_t flags, void *userdata) {
static const sd_json_dispatch_field dns_scope_dispatch_table[] = {
{ "protocol", SD_JSON_VARIANT_STRING, sd_json_dispatch_string, offsetof(DNSScope, protocol), SD_JSON_MANDATORY },
{ "family", SD_JSON_VARIANT_UNSIGNED, sd_json_dispatch_uint, offsetof(DNSScope, family), 0 },
{ "ifname", SD_JSON_VARIANT_STRING, sd_json_dispatch_string, offsetof(DNSScope, ifname), 0 },
{ "ifindex", SD_JSON_VARIANT_UNSIGNED, json_dispatch_ifindex, offsetof(DNSScope, ifindex), SD_JSON_RELAX },
{ "dnssec", SD_JSON_VARIANT_STRING, sd_json_dispatch_string, offsetof(DNSScope, dnssec_mode_str), 0 },
{ "dnsOverTLS", SD_JSON_VARIANT_STRING, sd_json_dispatch_string, offsetof(DNSScope, dns_over_tls_mode_str), 0 },
{},
};
DNSScope **ret = ASSERT_PTR(userdata);
int r;
_cleanup_(dns_scope_freep) DNSScope *s = new0(DNSScope, 1);
if (!s)
return log_oom();
r = sd_json_dispatch(variant, dns_scope_dispatch_table, flags, s);
if (r < 0)
return r;
*ret = TAKE_PTR(s);
return 0;
}
static int dispatch_dns_scope_array(const char *name, sd_json_variant *variant, sd_json_dispatch_flags_t flags, void *userdata) {
Set **ret = ASSERT_PTR(userdata);
_cleanup_set_free_ Set *dns_scopes = NULL;
sd_json_variant *v;
int r;
JSON_VARIANT_ARRAY_FOREACH(v, variant) {
_cleanup_(dns_scope_freep) DNSScope *s = NULL;
r = dispatch_dns_scope(name, v, flags, &s);
if (r < 0)
return json_log(v, flags, r, "JSON array element is not a valid DNSScope.");
r = set_ensure_consume(&dns_scopes, &dns_scope_hash_ops, TAKE_PTR(s));
if (r < 0)
return r;
}
set_free_and_replace(*ret, dns_scopes);
return 0;
}
DNSConfiguration* dns_configuration_free(DNSConfiguration *c) {
if (!c)
return NULL;
@@ -159,6 +228,7 @@ DNSConfiguration* dns_configuration_free(DNSConfiguration *c) {
set_free(c->dns_servers);
set_free(c->search_domains);
set_free(c->fallback_dns_servers);
set_free(c->dns_scopes);
free(c->ifname);
free(c->dnssec_mode_str);
free(c->dns_over_tls_mode_str);
@@ -193,10 +263,10 @@ static int dispatch_dns_configuration(const char *name, sd_json_variant *variant
{ "fallbackServers", SD_JSON_VARIANT_ARRAY, dispatch_dns_server_array, offsetof(DNSConfiguration, fallback_dns_servers), 0 },
{ "negativeTrustAnchors", SD_JSON_VARIANT_ARRAY, sd_json_dispatch_strv, offsetof(DNSConfiguration, negative_trust_anchors), 0 },
{ "resolvConfMode", SD_JSON_VARIANT_STRING, sd_json_dispatch_string, offsetof(DNSConfiguration, resolv_conf_mode_str), 0 },
{ "scopes", SD_JSON_VARIANT_ARRAY, dispatch_dns_scope_array, offsetof(DNSConfiguration, dns_scopes), 0 },
/* The remaining fields are currently unused by wait-online. */
{ "delegate", _SD_JSON_VARIANT_TYPE_INVALID, NULL, 0, 0 },
{ "scopes", _SD_JSON_VARIANT_TYPE_INVALID, NULL, 0, 0 },
{},
};
+13
View File
@@ -23,6 +23,18 @@ typedef struct SearchDomain {
int ifindex;
} SearchDomain;
typedef struct DNSScope {
char *ifname;
int ifindex;
char *protocol;
int family;
char *dnssec_mode_str;
char *dns_over_tls_mode_str;
} DNSScope;
DNSScope* dns_scope_free(DNSScope *s);
DEFINE_TRIVIAL_CLEANUP_FUNC(DNSScope*, dns_scope_free);
SearchDomain* search_domain_free(SearchDomain *d);
DEFINE_TRIVIAL_CLEANUP_FUNC(SearchDomain*, search_domain_free);
@@ -34,6 +46,7 @@ typedef struct DNSConfiguration {
Set *dns_servers;
Set *search_domains;
Set *fallback_dns_servers;
Set *dns_scopes;
char *dnssec_mode_str;
char *dns_over_tls_mode_str;
char *llmnr_mode_str;