SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bus-polkit: fix memory leak

Browse Source 
We need to destroy the hashmap entry keyed by the varlink object in case
this is a varlink request.

Follow-up for: d04c1a1c8e
This commit is contained in:
Lennart Poettering
2024-01-08 19:06:13 +01:00
parent aafaafb6f7
commit 4bcd606815
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/shared/bus-polkit.c
+8 -4
View File
@@ -192,9 +192,9 @@ typedef struct AsyncPolkitQuery {
AsyncPolkitQueryAction *action;
sd_bus *bus;
sd_bus_message *request;
sd_bus_message *request; /* the original bus method call that triggered the polkit auth, NULL in case of varlink */
sd_bus_slot *slot;
Varlink *link;
Varlink *link; /* the original varlink method call that triggered the polkit auth, NULL in case of bus */
Hashmap *registry;
sd_event_source *defer_event_source;
@@ -211,8 +211,12 @@ static AsyncPolkitQuery *async_polkit_query_free(AsyncPolkitQuery *q) {
sd_bus_slot_unref(q->slot);
if (q->registry && q->request)
hashmap_remove(q->registry, q->request);
if (q->registry) {
if (q->request)
hashmap_remove(q->registry, q->request);
if (q->link)
hashmap_remove(q->registry, q->link);
}
sd_bus_message_unref(q->request);