journal: add assert for max_size overflow safety
Coverity flags max_size*2 as a potential overflow. The value is
bounded by MAX_SIZE_UPPER (128 MiB) or JOURNAL_COMPACT_SIZE_MAX
(4 GiB), so doubling is safe within uint64_t. Add an assert to
document this.
CID#1548019
Follow-up for 8580d1f73d
This commit is contained in:
@@ -4058,6 +4058,8 @@ static void journal_default_metrics(JournalMetrics *m, int fd, bool compact) {
|
||||
if (m->max_size < JOURNAL_FILE_SIZE_MIN)
|
||||
m->max_size = JOURNAL_FILE_SIZE_MIN;
|
||||
|
||||
/* Silence static analyzers */
|
||||
assert(m->max_size <= UINT64_MAX / 2);
|
||||
if (m->max_use != 0 && m->max_size*2 > m->max_use)
|
||||
m->max_use = m->max_size*2;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user