sd-journal: detect earlier if we try to read an object from an invalid offset

Specifically, detect early if we try to read from offset 0, i.e. are using uninitialized offset data.
2016-04-26 12:00:02 +02:00
parent 1000522a60
commit 50809d7a9c
1 changed files with 4 additions and 0 deletions
@@ -709,6 +709,10 @@ int journal_file_move_to_object(JournalFile *f, ObjectType type, uint64_t offset
        if (!VALID64(offset))
                return -EFAULT;

+        /* Object may not be located in the file header */
+        if (offset < le64toh(f->header->header_size))
+                return -EBADMSG;
+
        r = journal_file_move_to(f, type, false, offset, sizeof(ObjectHeader), &t);
        if (r < 0)
                return r;