SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bootctl: do not print special glyphs to the log

Browse Source 
The log line looked like this:
  bootctl[1457]: ! Mount point '/efi' which backs the random seed file is world accessible, which is a security hole! !
which doesn't look nice.

Also upgrade the message to error. This is something to fix.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek
2025-03-15 14:40:52 +01:00
parent 75d51d77da
commit 6012a52aba
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bootctl/bootctl-random-seed.c
+9 -7
View File
@@ -40,13 +40,15 @@ static int random_seed_verify_permissions(int fd, mode_t expected_type) {
return 0;
if (S_ISREG(expected_type))
log_warning("%s Random seed file '%s' is world accessible, which is a security hole! %s",
glyph(GLYPH_WARNING_SIGN), full_path, glyph(GLYPH_WARNING_SIGN));
else {
assert(S_ISDIR(expected_type));
log_warning("%s Mount point '%s' which backs the random seed file is world accessible, which is a security hole! %s",
glyph(GLYPH_WARNING_SIGN), full_path, glyph(GLYPH_WARNING_SIGN));
}
log_error("%s%sRandom seed file '%s' is world accessible, which is a security hole!%s%s",
optional_glyph(GLYPH_WARNING_SIGN), optional_glyph(GLYPH_SPACE),
full_path,
optional_glyph(GLYPH_SPACE), optional_glyph(GLYPH_WARNING_SIGN));
else
log_error("%s%s Mount point '%s' which backs the random seed file is world accessible, which is a security hole! %s%s",
optional_glyph(GLYPH_WARNING_SIGN), optional_glyph(GLYPH_SPACE),
full_path,
optional_glyph(GLYPH_SPACE), optional_glyph(GLYPH_WARNING_SIGN));
return 1;
}