SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

varlink: add short comment that the log message is checked in test

Browse Source 
Follow-up for 038e455462.
This commit is contained in:
Yu Watanabe
2024-01-30 15:41:52 +00:00
committed by Luca Boccassi
parent 9c41e4eb2f
commit 613d953988
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/shared/varlink.c
+12 -4
View File
@@ -1439,7 +1439,9 @@ static int varlink_dispatch_method(Varlink *v) {
r = varlink_idl_validate_method_call(v->current_method, parameters, &bad_field);
if (r < 0) {
varlink_log_errno(v, r, "Parameters for method %s() didn't pass validation on field '%s': %m", method, strna(bad_field));
/* Please adjust test/units/end.sh when updating the log message. */
varlink_log_errno(v, r, "Parameters for method %s() didn't pass validation on field '%s': %m",
method, strna(bad_field));
if (IN_SET(v->state, VARLINK_PROCESSING_METHOD, VARLINK_PROCESSING_METHOD_MORE)) {
r = varlink_error_invalid_parameter_name(v, bad_field);
@@ -2494,7 +2496,9 @@ int varlink_reply(Varlink *v, JsonVariant *parameters) {
r = varlink_idl_validate_method_reply(v->current_method, parameters, &bad_field);
if (r < 0)
varlink_log_errno(v, r, "Return parameters for method reply %s() didn't pass validation on field '%s', ignoring: %m", v->current_method->name, strna(bad_field));
/* Please adjust test/units/end.sh when updating the log message. */
varlink_log_errno(v, r, "Return parameters for method reply %s() didn't pass validation on field '%s', ignoring: %m",
v->current_method->name, strna(bad_field));
}
r = varlink_enqueue_json(v, m);
@@ -2571,7 +2575,9 @@ int varlink_error(Varlink *v, const char *error_id, JsonVariant *parameters) {
r = varlink_idl_validate_error(symbol, parameters, &bad_field);
if (r < 0)
varlink_log_errno(v, r, "Parameters for error %s didn't pass validation on field '%s', ignoring: %m", error_id, strna(bad_field));
/* Please adjust test/units/end.sh when updating the log message. */
varlink_log_errno(v, r, "Parameters for error %s didn't pass validation on field '%s', ignoring: %m",
error_id, strna(bad_field));
}
r = varlink_enqueue_json(v, m);
@@ -2693,7 +2699,9 @@ int varlink_notify(Varlink *v, JsonVariant *parameters) {
r = varlink_idl_validate_method_reply(v->current_method, parameters, &bad_field);
if (r < 0)
varlink_log_errno(v, r, "Return parameters for method reply %s() didn't pass validation on field '%s', ignoring: %m", v->current_method->name, strna(bad_field));
/* Please adjust test/units/end.sh when updating the log message. */
varlink_log_errno(v, r, "Return parameters for method reply %s() didn't pass validation on field '%s', ignoring: %m",
v->current_method->name, strna(bad_field));
}
r = varlink_enqueue_json(v, m);