hibernate-resume: restore full message if resume fails

We had a INFO message before 760e99bb52. Logging
at INFO level made sense back when we didn't have the EFI variable and people
would set resume= on the kernel command line. Nowadays, if we have the
hibernation info, then we expect it to be accurate. Log at WARN level if we
have the EFI variable and the resume fails for any reason, and at INFO
otherwise.

OTOH, we already print errors immediately when that happens, and if the resume
failed in the kernel, the kernel should log on its own. So just use WARN, not
ERR.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek
2025-04-01 11:25:32 +02:00
parent 451277707d
commit 61b76b3a1a
+1 -2
View File
@@ -172,11 +172,10 @@ static int run(int argc, char *argv[]) {
/* The write shall not return if a resume takes place. */
r = write_resume_config(st.st_rdev, arg_info.offset, arg_info.device);
log_full_errno(r < 0 ? LOG_ERR : LOG_DEBUG,
log_full_errno(r < 0 || arg_info.efi ? LOG_WARNING : LOG_INFO,
r < 0 ? r : SYNTHETIC_ERRNO(ENOENT),
"Unable to resume from device '%s' (" DEVNUM_FORMAT_STR ") offset %" PRIu64 ", continuing boot process.",
arg_info.device, DEVNUM_FORMAT_VAL(st.st_rdev), arg_info.offset);
return r;
}