sd-device: use path_compare() rather than strcmp() for sorting paths

When sorting paths it actually matters to use the right comparison
function. Example:

```
a/x
a-b/y
a_/z
```

I think people would probably expect this:

```
a/x
a-b/y
a_a/z
```

but if you use strcmp() instead of path_compare() you'd instead get:

```
a-b/y
a/x
a_a/z
```

That's because `/` is between `-` and `a` in the ascii table. I think
that's quite confusing, and we shouldn#t order that way hence.

As discussed: https://github.com/systemd/systemd/pull/22662#discussion_r831174776
This commit is contained in:
Lennart Poettering
2022-03-22 13:10:41 +01:00
parent a3f47f48b0
commit 63aac21c5e
+1 -1
View File
@@ -323,7 +323,7 @@ static int device_compare(sd_device * const *a, sd_device * const *b) {
if (r != 0)
return r;
return strcmp(devpath_a, devpath_b);
return path_compare(devpath_a, devpath_b);
}
static int enumerator_sort_devices(sd_device_enumerator *enumerator) {