SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: handle NULL correctly when passed to ASSERT_EQ()

Browse Source 
strcmp() doesn't handle NULLs nicely, so switch to streq_ptr().
This commit is contained in:
Frantisek Sumsal
2024-04-09 21:39:46 +02:00
parent edda10f2ae
commit 7d7a3d4787
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/shared/tests.h
+3 -4
View File
@@ -249,11 +249,10 @@ static inline int run_test_table(void) {
#define ASSERT_STREQ(expr1, expr2) \
({ \
const char* _expr1 = (expr1); \
const char* _expr2 = (expr2); \
if (strcmp(_expr1, _expr2) != 0) { \
const char *_expr1 = (expr1), *_expr2 = (expr2); \
if (!streq_ptr(_expr1, _expr2)) { \
log_error("%s:%i: Assertion failed: expected \"%s == %s\", but \"%s != %s\"", \
PROJECT_FILE, __LINE__, #expr1, #expr2, _expr1, _expr2); \
PROJECT_FILE, __LINE__, #expr1, #expr2, strnull(_expr1), strnull(_expr2)); \
abort(); \
} \
})