SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test-bus-address: silence gcc warning about NULL arg to strcmp()

Browse Source 
The code was overly complicated… We know what value we expect, we can test it
directly.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek
2022-06-09 07:53:06 +02:00
parent 1b3502b072
commit 817d19402f
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libsystemd/sd-bus/test-bus-address.c
+5 -7
View File
@@ -15,11 +15,9 @@ static void test_one_address(sd_bus *b,
r = bus_set_address_system_remote(b, host);
log_info("\"%s\" → %d, \"%s\"", host, r, strna(r >= 0 ? b->address : NULL));
if (result < 0 || expected) {
assert_se(r == result);
if (r >= 0)
assert_se(streq(b->address, expected));
}
assert_se(r == result);
if (r >= 0)
assert_se(streq_ptr(b->address, expected));
}
TEST(bus_set_address_system_remote) {
@@ -38,8 +36,8 @@ TEST(bus_set_address_system_remote) {
0, "unixexec:path=ssh,argv1=-xT,argv2=-p,argv3=123,argv4=--,argv5=host,argv6=systemd-stdio-bridge");
test_one_address(b, "host:123:123",
-EINVAL, NULL);
test_one_address(b, "host:",
-EINVAL, NULL);
test_one_address(b, "host:",
-EINVAL, NULL);
test_one_address(b, "user@host",
0, "unixexec:path=ssh,argv1=-xT,argv2=--,argv3=user%40host,argv4=systemd-stdio-bridge");
test_one_address(b, "user@host@host",