nspawn: and also add comment, making clear chdir() should come late

2024-02-06 11:13:28 +01:00
parent f94025a136
commit 83d5dab4de
1 changed files with 3 additions and 0 deletions
@@ -3522,6 +3522,9 @@ static int inner_child(
        if (!barrier_place_and_sync(barrier)) /* #5 */
                return log_error_errno(SYNTHETIC_ERRNO(ESRCH), "Parent died too early");

+        /* Note, this should be done this late (💣 and not moved earlier! 💣), so that all namespacing
+         * changes are already in effect by now, so that any resolved paths here definitely reference
+         * resources inside the container, and not outside of them. */
        if (arg_chdir)
                if (chdir(arg_chdir) < 0)
                        return log_error_errno(errno, "Failed to change to specified working directory %s: %m", arg_chdir);