tree-wide: Remove unused includes (#39023)

src/analyze/analyze-unit-shell.c

@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 
-#include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
 

src/basic/ansi-color.c

@@ -3,7 +3,6 @@
 #include <stdlib.h>
 
 #include "ansi-color.h"
-#include "log.h"
 #include "process-util.h"
 #include "string-table.h"
 #include "string-util.h"

src/basic/env-file.c

@@ -6,7 +6,6 @@
 #include "alloc-util.h"
 #include "env-file.h"
 #include "env-util.h"
-#include "errno-util.h"
 #include "escape.h"
 #include "fd-util.h"
 #include "fileio.h"

src/basic/fd-util.c

@@ -20,7 +20,6 @@
 #include "parse-util.h"
 #include "path-util.h"
 #include "process-util.h"
-#include "socket-util.h"
 #include "sort-util.h"
 #include "stat-util.h"
 #include "stdio-util.h"

src/basic/filesystems.c

@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 
 #include "filesystems-gperf.h"
-#include "nulstr-util.h"
 #include "stat-util.h"
 #include "string-util.h"
 

src/core/exec-invoke.c

@@ -62,7 +62,6 @@
 #include "open-file.h"
 #include "osc-context.h"
 #include "path-util.h"
-#include "percent-util.h"
 #include "pidref.h"
 #include "proc-cmdline.h"
 #include "process-util.h"

src/core/namespace.c

@@ -38,7 +38,6 @@
 #include "nsflags.h"
 #include "nulstr-util.h"
 #include "os-util.h"
-#include "parse-util.h"
 #include "path-util.h"
 #include "pidref.h"
 #include "process-util.h"

src/core/unit.c

@@ -35,7 +35,6 @@
 #include "id128-util.h"
 #include "install.h"
 #include "iovec-util.h"
-#include "label-util.h"
 #include "load-dropin.h"
 #include "load-fragment.h"
 #include "log.h"

src/core/varlink-dynamic-user.c

@@ -3,7 +3,6 @@
 #include "sd-varlink.h"
 
 #include "dynamic-user.h"
-#include "errno-util.h"
 #include "hashmap.h"
 #include "json-util.h"
 #include "manager.h"

src/core/varlink-unit.c

@@ -13,9 +13,7 @@
 #include "set.h"
 #include "strv.h"
 #include "unit.h"
-#include "unit-name.h"
 #include "varlink-cgroup.h"
-#include "varlink-common.h"
 #include "varlink-unit.h"
 #include "varlink-util.h"
 

src/core/varlink.c

@@ -4,7 +4,6 @@
 
 #include "constants.h"
 #include "errno-util.h"
-#include "json-util.h"
 #include "manager.h"
 #include "path-util.h"
 #include "pidref.h"

src/fsck/fsck.c

@@ -22,7 +22,6 @@
 #include "fs-util.h"
 #include "fsck-util.h"
 #include "main-func.h"
-#include "parse-util.h"
 #include "path-util.h"
 #include "proc-cmdline.h"
 #include "process-util.h"

src/fuzz/fuzz-varlink.c

@@ -9,7 +9,6 @@
 #include "fuzz.h"
 #include "hexdecoct.h"
 #include "iovec-util.h"
-#include "log.h"
 
 static FILE *null = NULL;
 

src/import/pull-common.c

@@ -6,7 +6,6 @@
 #include "dirent-util.h"
 #include "escape.h"
 #include "fd-util.h"
-#include "hexdecoct.h"
 #include "io-util.h"
 #include "log.h"
 #include "memory-util.h"

src/import/pull-job.c

@@ -759,7 +759,7 @@ int pull_job_begin(PullJob *j) {
         if (curl_easy_setopt(j->curl, CURLOPT_XFERINFODATA, j) != CURLE_OK)
                 return -EIO;
 
-        if (curl_easy_setopt(j->curl, CURLOPT_NOPROGRESS, 0) != CURLE_OK)
+        if (curl_easy_setopt(j->curl, CURLOPT_NOPROGRESS, 0L) != CURLE_OK)
                 return -EIO;
 
         r = curl_glue_add(j->glue, j->curl);

src/include/override/fcntl.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include_next <fcntl.h>
+#include_next <fcntl.h>         /* IWYU pragma: export */
 
 /* This is defined since glibc-2.41. */
 #ifndef F_DUPFD_QUERY

src/include/override/malloc.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include_next <malloc.h>
+#include_next <malloc.h>        /* IWYU pragma: export */
 
 #if !HAVE_MALLINFO2
 struct mallinfo2 {

src/include/override/sched.h

@@ -6,7 +6,7 @@
  * Note, this must be included before sched.h, otherwise the headers conflict with each other. */
 #include <linux/sched/types.h>
 
-#include_next <sched.h>
+#include_next <sched.h>         /* IWYU pragma: export */
 
 #include <assert.h>
 

src/include/override/signal.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include_next <signal.h>
+#include_next <signal.h>        /* IWYU pragma: export */
 
 #if !HAVE_RT_TGSIGQUEUEINFO
 int missing_rt_tgsigqueueinfo(pid_t tgid, pid_t tid, int sig, siginfo_t *info);

src/include/override/sys/mman.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include_next <sys/mman.h>
+#include_next <sys/mman.h>      /* IWYU pragma: export */
 
 #include <assert.h>
 

src/include/override/sys/pidfd.h

@@ -3,7 +3,7 @@
 
 /* since glibc-2.36 */
 #if HAVE_PIDFD_OPEN
-#include_next <sys/pidfd.h>
+#include_next <sys/pidfd.h>     /* IWYU pragma: export */
 #endif
 
 #include <linux/types.h>

src/include/override/sys/quota.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include_next <sys/quota.h>
+#include_next <sys/quota.h>     /* IWYU pragma: export */
 
 /* Supported since kernel v5.14 (64c2c2c62f92339b176ea24403d8db16db36f9e6). */
 #if !HAVE_QUOTACTL_FD

src/include/override/sys/random.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include_next <sys/random.h>
+#include_next <sys/random.h>    /* IWYU pragma: export */
 
 #include <assert.h>
 

src/include/override/sys/socket.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include_next <sys/socket.h>
+#include_next <sys/socket.h>    /* IWYU pragma: export */
 
 /* Supported since kernel v6.5 (5e2ff6704a275be009be8979af17c52361b79b89) */
 #ifndef SO_PASSPIDFD

src/include/override/sys/stat.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include_next <sys/stat.h>
+#include_next <sys/stat.h>      /* IWYU pragma: export */
 
 /* Supported since kernel v6.6 (78252deb023cf0879256fcfbafe37022c390762b). */
 #if !HAVE_FCHMODAT2

src/include/override/sys/syscall.h

@@ -9,7 +9,7 @@
  */
 #pragma once
 
-#include_next <sys/syscall.h>
+#include_next <sys/syscall.h>   /* IWYU pragma: export */
 
 #ifdef ARCH_MIPS
 #include <asm/sgidefs.h>

src/include/override/sys/wait.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include_next <sys/wait.h>
+#include_next <sys/wait.h>      /* IWYU pragma: export */
 
 #include <assert.h>
 

src/include/override/sys/xattr.h

@@ -3,9 +3,9 @@
 
 /* To make struct xattr_args defined, which is used by setxattrat(). Note, the kernel header must be
  * included before the glibc header, otherwise the struct will not be defined. */
-#include <linux/xattr.h>
+#include <linux/xattr.h>        /* IWYU pragma: export */
 
-#include_next <sys/xattr.h>
+#include_next <sys/xattr.h>     /* IWYU pragma: export */
 
 /* Supported since kernel v6.13 (6140be90ec70c39fa844741ca3cc807dd0866394). */
 #if !HAVE_SETXATTRAT

src/include/override/unistd.h

@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 #pragma once
 
-#include_next <unistd.h>
+#include_next <unistd.h>        /* IWYU pragma: export */
 
 /* Defined since glibc-2.34.
  * Supported since kernel v5.9 (9b4feb630e8e9801603f3cab3a36369e3c1cf88d). */

src/journal-remote/journal-upload.c

@@ -308,7 +308,7 @@ int start_upload(Uploader *u,
                 }
 
                 if (STRPTR_IN_SET(arg_trust, "-", "all"))
-                        easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0,
+                        easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L,
                                     LOG_ERR, return -EUCLEAN);
                 else if (arg_trust || startswith(u->url, "https://"))
                         easy_setopt(curl, CURLOPT_CAINFO, arg_trust ?: TRUST_FILE,

src/journal/journald-manager.c

@@ -18,8 +18,6 @@
 #include "alloc-util.h"
 #include "audit-util.h"
 #include "cgroup-util.h"
-#include "conf-parser.h"
-#include "creds-util.h"
 #include "daemon-util.h"
 #include "dirent-util.h"
 #include "errno-util.h"
@@ -53,14 +51,12 @@
 #include "log-ratelimit.h"
 #include "memory-util.h"
 #include "mkdir.h"
-#include "parse-util.h"
 #include "path-util.h"
 #include "prioq.h"
 #include "process-util.h"
 #include "rm-rf.h"
 #include "set.h"
 #include "signal-util.h"
-#include "socket-netlink.h"
 #include "socket-util.h"
 #include "stdio-util.h"
 #include "string-util.h"

src/journal/journald-manager.h

@@ -7,7 +7,6 @@
 #include "journald-forward.h"
 #include "list.h"
 #include "ratelimit.h"
-#include "socket-util.h"
 
 typedef struct JournalStorageSpace {
         usec_t   timestamp;

src/journal/test-journald-tables.c

@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 
-#include "journald-manager.h"
+#include "journald-config.h"
 #include "test-tables.h"
 #include "tests.h"
 

src/libsystemd-network/sd-dhcp-client-id.c

@@ -4,7 +4,6 @@
 #include "dhcp-client-id-internal.h"
 #include "iovec-util.h"
 #include "json-util.h"
-#include "log.h"
 #include "siphash24.h"
 #include "string-util.h"
 #include "unaligned.h"

src/libsystemd-network/test-lldp-rx.c

@@ -6,10 +6,10 @@
 #include <unistd.h>
 
 #include "sd-event.h"
+#include "sd-json.h"
 #include "sd-lldp-rx.h"
 
 #include "fd-util.h"
-#include "json-util.h"
 #include "lldp-neighbor.h"
 #include "lldp-network.h"
 #include "tests.h"

src/libsystemd/sd-journal/journal-file.c

@@ -34,7 +34,6 @@
 #include "path-util.h"
 #include "prioq.h"
 #include "random-util.h"
-#include "ratelimit.h"
 #include "sort-util.h"
 #include "stat-util.h"
 #include "string-table.h"

src/libsystemd/sd-journal/journal-send.c

@@ -16,7 +16,6 @@
 #include "io-util.h"
 #include "iovec-util.h"
 #include "journal-send.h"
-#include "log.h"
 #include "memfd-util.h"
 #include "process-util.h"
 #include "socket-util.h"

src/libsystemd/sd-journal/journal-vacuum.c

@@ -16,7 +16,6 @@
 #include "journal-vacuum.h"
 #include "log.h"
 #include "log-ratelimit.h"
-#include "ratelimit.h"
 #include "sort-util.h"
 #include "string-util.h"
 #include "time-util.h"

src/libsystemd/sd-netlink/netlink-message-nfnl.c

@@ -9,7 +9,6 @@
 #include "alloc-util.h"
 #include "errno-util.h"
 #include "iovec-util.h"
-#include "log.h"
 #include "netlink-internal.h"
 #include "netlink-util.h"
 

src/libsystemd/sd-resolve/sd-resolve.c

@@ -19,7 +19,6 @@
 #include "io-util.h"
 #include "iovec-util.h"
 #include "list.h"
-#include "log.h"
 #include "memory-util.h"
 #include "process-util.h"
 #include "resolve-private.h"

src/machine/machine.c

@@ -15,7 +15,6 @@
 #include "bus-unit-util.h"
 #include "env-file.h"
 #include "errno-util.h"
-#include "escape.h"
 #include "extract-word.h"
 #include "fd-util.h"
 #include "fileio.h"

src/network/networkd-ipv6ll.c

@@ -15,7 +15,6 @@
 #include "siphash24.h"
 #include "socket-util.h"
 #include "string-table.h"
-#include "string-util.h"
 #include "strv.h"
 #include "sysctl-util.h"
 

src/nspawn/nspawn-settings.c

@@ -13,7 +13,6 @@
 #include "nspawn-network.h"
 #include "nspawn-settings.h"
 #include "parse-util.h"
-#include "path-util.h"
 #include "process-util.h"
 #include "rlimit-util.h"
 #include "socket-util.h"

src/resolve/resolved-dns-browse-services.c

@@ -1,9 +1,10 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 
 #include "af-list.h"
+#include "alloc-util.h"
 #include "event-util.h"
 #include "dns-domain.h"
-#include "json-util.h"
+#include "log.h"
 #include "random-util.h"
 #include "resolved-dns-browse-services.h"
 #include "resolved-dns-cache.h"
@@ -12,8 +13,8 @@
 #include "resolved-dns-rr.h"
 #include "resolved-dns-scope.h"
 #include "resolved-manager.h"
-#include "resolved-varlink.h"
 #include "string-table.h"
+#include "string-util.h"
 
 typedef enum BrowseServiceUpdateEvent {
         BROWSE_SERVICE_UPDATE_ADDED,

src/resolve/resolved-dnstls.c

@@ -7,7 +7,6 @@
 #include <openssl/bio.h>
 #include <openssl/err.h>
 #include <openssl/x509v3.h>
-#include <sys/epoll.h>
 
 #include "alloc-util.h"
 #include "openssl-util.h"

src/resolve/resolved-varlink.c

@@ -7,7 +7,6 @@
 #include "dns-domain.h"
 #include "dns-type.h"
 #include "errno-util.h"
-#include "glyph-util.h"
 #include "in-addr-util.h"
 #include "iovec-util.h"
 #include "json-util.h"

src/run/run.c

@@ -5,7 +5,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <sys/resource.h>
-#include <sys/stat.h>
 #include <unistd.h>
 
 #include "sd-bus.h"

src/shared/cpu-set-util.c

@@ -8,7 +8,6 @@
 #include "bitfield.h"
 #include "cpu-set-util.h"
 #include "extract-word.h"
-#include "hexdecoct.h"
 #include "log.h"
 #include "parse-util.h"
 #include "string-util.h"

src/shared/generator.c

@@ -6,7 +6,6 @@
 
 #include "alloc-util.h"
 #include "argv-util.h"
-#include "cgroup-util.h"
 #include "dropin.h"
 #include "escape.h"
 #include "fd-util.h"

src/shared/label-util.c

@@ -5,7 +5,6 @@
 
 #include "btrfs-util.h"
 #include "errno-util.h"
-#include "fs-util.h"
 #include "label-util.h"
 #include "selinux-util.h"
 #include "smack-util.h"

src/shared/libaudit-util.c

@@ -2,7 +2,6 @@
 
 #include <linux/audit.h>
 #include <linux/netlink.h>
-#include <stdio.h>
 #include <sys/socket.h>
 
 #include "errno-util.h"

src/shared/machine-bind-user.c

@@ -2,7 +2,6 @@
 
 #include <grp.h>
 #include <pwd.h>
-#include <unistd.h>
 
 #include "alloc-util.h"
 #include "chase.h"

src/shared/pretty-print.c

@@ -14,7 +14,6 @@
 #include "errno-util.h"
 #include "fd-util.h"
 #include "fileio.h"
-#include "fs-util.h"
 #include "log.h"
 #include "path-util.h"
 #include "pretty-print.h"

src/shared/tests.c

@@ -3,8 +3,6 @@
 #include <sched.h>
 #include <stdlib.h>
 #include <sys/mman.h>
-#include <sys/prctl.h>
-#include <sys/wait.h>
 #include <unistd.h>
 
 #include "sd-bus.h"

src/systemctl/systemctl-compat-shutdown.c

@@ -11,7 +11,6 @@
 #include "strv.h"
 #include "systemctl.h"
 #include "systemctl-compat-shutdown.h"
-#include "systemctl-logind.h"
 #include "time-util.h"
 
 static int shutdown_help(void) {

src/sysupdate/sysupdate.c

@@ -6,12 +6,9 @@
 #include "sd-daemon.h"
 
 #include "build.h"
-#include "chase.h"
 #include "conf-files.h"
 #include "constants.h"
-#include "dirent-util.h"
 #include "dissect-image.h"
-#include "fd-util.h"
 #include "format-table.h"
 #include "glyph-util.h"
 #include "hexdecoct.h"

src/test/test-bpf-firewall.c

@@ -9,7 +9,6 @@
 #include "in-addr-prefix-util.h"
 #include "load-fragment.h"
 #include "manager.h"
-#include "memory-util.h"
 #include "path-util.h"
 #include "rm-rf.h"
 #include "service.h"

src/test/test-fd-util.c

@@ -17,7 +17,6 @@
 #include "random-util.h"
 #include "rlimit-util.h"
 #include "rm-rf.h"
-#include "seccomp-util.h"
 #include "serialize.h"
 #include "stat-util.h"
 #include "tests.h"

src/test/test-glob-util.c

@@ -1,11 +1,9 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 
 #include <stdlib.h>
-#include <sys/stat.h>
 #include <unistd.h>
 
 #include "alloc-util.h"
-#include "dirent-util.h"
 #include "fs-util.h"
 #include "glob-util.h"
 #include "rm-rf.h"

src/test/test-journal-importer.c

@@ -4,7 +4,6 @@
 
 #include "alloc-util.h"
 #include "journal-importer.h"
-#include "log.h"
 #include "tests.h"
 
 static void assert_iovec_entry(const struct iovec *iovec, const char* content) {

src/test/test-macro.c

@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1-or-later */
 
-#include "errno-util.h"
 #include "tests.h"
 
 TEST(saturate_add) {

src/test/test-mount-util.c

@@ -14,7 +14,6 @@
 #include "mkdir.h"
 #include "mount-util.h"
 #include "mountpoint-util.h"
-#include "namespace-util.h"
 #include "path-util.h"
 #include "process-util.h"
 #include "random-util.h"

src/test/test-parse-util.c

@@ -3,7 +3,6 @@
 #include <linux/netfilter/nf_tables.h>
 #include <locale.h>
 #include <math.h>
-#include <stdlib.h>
 #include <sys/socket.h>
 
 #include "locale-util.h"

src/test/test-tables.c

@@ -35,7 +35,6 @@
 #include "tests.h"
 #include "timer.h"
 #include "unit.h"
-#include "unit-name.h"
 #include "virt.h"
 
 int main(int argc, char **argv) {

src/update-utmp/update-utmp.c

@@ -4,19 +4,13 @@
 
 #include "sd-bus.h"
 
-#include "alloc-util.h"
 #include "bus-error.h"
 #include "bus-locator.h"
 #include "bus-util.h"
 #include "libaudit-util.h"
 #include "log.h"
 #include "main-func.h"
-#include "random-util.h"
-#include "special.h"
-#include "stdio-util.h"
-#include "strv.h"
 #include "time-util.h"
-#include "unit-def.h"
 #include "utmp-wtmp.h"
 #include "verbs.h"
 

src/vmspawn/vmspawn-register.c

@@ -13,7 +13,6 @@
 #include "json-util.h"
 #include "log.h"
 #include "pidref.h"
-#include "process-util.h"
 #include "socket-util.h"
 #include "string-util.h"
 #include "terminal-util.h"