SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test-path-util: add coverage for path edge cases

Browse Source 
Path utility helpers are used throughout systemd for validation, comparison and manipulation of filesystem paths. Add coverage for additional corner cases around absolute path detection, normalization and prefix matching so regressions in these common helpers are easier to catch.

Co-developed-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: favilances <favilances@proton.me>
This commit is contained in:
favilances
2026-05-11 10:23:37 +01:00
committed by Luca Boccassi
parent 0bf094b763
commit 87d282a73d
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/test-path-util.c
+22
View File
@@ -24,8 +24,12 @@ TEST(print_paths) {
}
TEST(path) {
assert_se(!path_is_absolute(NULL));
assert_se(!path_is_absolute(""));
assert_se( path_is_absolute("/"));
assert_se( path_is_absolute("//"));
assert_se(!path_is_absolute("./"));
assert_se(!path_is_absolute("foo/bar"));
assert_se( PATH_IN_SET("/bin", "/", "/bin", "/foo"));
assert_se( PATH_IN_SET("/bin", "/bin"));
@@ -42,6 +46,21 @@ TEST(path) {
assert_se(!path_equal(NULL, "a"));
}
TEST(path_is_normalized) {
assert_se( path_is_normalized("/"));
assert_se( path_is_normalized("/usr/bin"));
assert_se( path_is_normalized("usr/bin"));
assert_se(!path_is_normalized(""));
assert_se(!path_is_normalized("."));
assert_se(!path_is_normalized("./usr/bin"));
assert_se(!path_is_normalized("/usr//bin"));
assert_se(!path_is_normalized("/usr/./bin"));
assert_se(!path_is_normalized("/usr/bin/."));
assert_se(!path_is_normalized("../usr/bin"));
assert_se(!path_is_normalized("/usr/../bin"));
}
TEST(is_path) {
assert_se(!is_path("foo"));
assert_se(!is_path("dos.ext"));
@@ -760,6 +779,9 @@ TEST(path_startswith) {
test_path_startswith_one("/foo/bar/barfoo/", "/foo/bar/barfo", NULL, NULL);
test_path_startswith_one("/foo/bar/barfoo/", "/foo/bar/bar", NULL, NULL);
test_path_startswith_one("/foo/bar/barfoo/", "/fo", NULL, NULL);
test_path_startswith_one("/usr/binary", "/usr/bin", NULL, NULL);
test_path_startswith_one("/foo/barista", "/foo/bar", NULL, NULL);
test_path_startswith_one("foo/barista", "foo/bar", NULL, NULL);
}
static void test_path_startswith_return_leading_slash_one(const char *path, const char *prefix, const char *expected) {