udev: variable dereferenced before check 'cmsg'

2015-08-06 13:46:49 +02:00
parent 0610939d6b
commit 93b1da8525
1 changed files with 2 additions and 1 deletions
@@ -379,13 +379,14 @@ struct udev_ctrl_msg *udev_ctrl_receive_msg(struct udev_ctrl_connection *conn) {
        cmsg_close_all(&smsg);

        cmsg = CMSG_FIRSTHDR(&smsg);
-        cred = (struct ucred *) CMSG_DATA(cmsg);

        if (cmsg == NULL || cmsg->cmsg_type != SCM_CREDENTIALS) {
                log_error("no sender credentials received, message ignored");
                goto err;
        }

+        cred = (struct ucred *) CMSG_DATA(cmsg);
+
        if (cred->uid != 0) {
                log_error("sender uid="UID_FMT", message ignored", cred->uid);
                goto err;