tpm2: fix nits from PR #26185
Fixes: - Comment style - Alignment style - cleanup macro usage - incorrect error message[1] 1. Thanks to tempusfugit991@gmail.com for pointing out the error message mistake. Signed-off-by: William Roberts <william.c.roberts@intel.com>
This commit is contained in:
committed by
Luca Boccassi
parent
d6d0661631
commit
96181b7a89
@@ -142,7 +142,7 @@ int enroll_tpm2(struct crypt_device *cd,
|
||||
_cleanup_(erase_and_freep) void *secret = NULL;
|
||||
_cleanup_(json_variant_unrefp) JsonVariant *v = NULL, *signature_json = NULL;
|
||||
_cleanup_(erase_and_freep) char *base64_encoded = NULL;
|
||||
_cleanup_(freep) void *srk_buf = NULL;
|
||||
_cleanup_free_ void *srk_buf = NULL;
|
||||
size_t secret_size, blob_size, hash_size, pubkey_size = 0, srk_buf_size = 0;
|
||||
_cleanup_free_ void *blob = NULL, *hash = NULL, *pubkey = NULL;
|
||||
uint16_t pcr_bank, primary_alg;
|
||||
|
||||
@@ -1035,10 +1035,8 @@ int decrypt_credential_and_warn(
|
||||
le32toh(z->size));
|
||||
}
|
||||
|
||||
/*
|
||||
* TODO: Add the SRK data to the credential structure so it can be plumbed
|
||||
* through and used to verify the TPM session.
|
||||
*/
|
||||
// TODO: Add the SRK data to the credential structure so it can be plumbed
|
||||
// through and used to verify the TPM session.
|
||||
r = tpm2_unseal(tpm2_device,
|
||||
le64toh(t->pcr_mask),
|
||||
le16toh(t->pcr_bank),
|
||||
|
||||
@@ -558,7 +558,7 @@ static int tpm2_make_primary(
|
||||
if (use_srk_model) {
|
||||
r = make_lock_file("/run/systemd/tpm2-srk-init", LOCK_EX, &srk_lock);
|
||||
if (r < 0)
|
||||
return log_error_errno(r, "Failed to take network zone lock: %m");
|
||||
return log_error_errno(r, "Failed to take TPM SRK lock: %m");
|
||||
}
|
||||
|
||||
/* Find existing SRK and use it if present */
|
||||
@@ -573,7 +573,7 @@ static int tpm2_make_primary(
|
||||
|
||||
if (alg != 0 && alg != got_alg)
|
||||
log_warning("Caller asked for specific algorithm %u, but existing SRK is %u, ignoring",
|
||||
alg, got_alg);
|
||||
alg, got_alg);
|
||||
|
||||
if (ret_alg)
|
||||
*ret_alg = alg;
|
||||
|
||||
Reference in New Issue
Block a user