test-execute: skip flaky test when we can't unshare namespaces

When running in Fedora "mock", / is a tmpfs and /home is not mounted. The test
assumes that /home will be a tmpfs only and only if we can unshare. Obviously,
this does not hold in this case, because unsharing is not possible, but /home
is still a tmpfs. Let's just skip the test, since it's fully legitimate to
mount either or both of / and /home as tmpfs.
This commit is contained in:
Zbigniew Jędrzejewski-Szmek
2019-03-26 18:53:53 +01:00
parent 6aed6a1157
commit 9ca5828475
+6 -1
View File
@@ -280,7 +280,12 @@ static void test_exec_privatedevices(Manager *m) {
}
static void test_exec_protecthome(Manager *m) {
test(__func__, m, "exec-protecthome-tmpfs-vs-protectsystem-strict.service", can_unshare ? 0 : EXIT_FAILURE, CLD_EXITED);
if (!can_unshare) {
log_notice("Cannot reliably unshare, skipping %s", __func__);
return;
}
test(__func__, m, "exec-protecthome-tmpfs-vs-protectsystem-strict.service", 0, CLD_EXITED);
}
static void test_exec_protectkernelmodules(Manager *m) {