SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

network: initialize dot_servers before CLEANUP_ARRAY

Browse Source 
If dns_resolvers_to_dot_addrs() fails (e.g. OOM) it returns without
assigning *ret_addrs, so the CLEANUP_ARRAY() cleanup would free an
uninitialized dot_servers pointer on the error return.

Follow-up for 3fd6708cde
This commit is contained in:
Luca Boccassi
2026-07-06 13:42:21 +01:00
parent a8d8009b7a
commit 9cae6d9c56
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/network/networkd-state-file.c
+2 -2
View File
@@ -134,7 +134,7 @@ static int link_put_dns(Link *link, OrderedSet **s) {
r = sd_dhcp_lease_get_dnr(link->dhcp_lease, &resolvers);
if (r >= 0) {
struct in_addr_full **dot_servers;
struct in_addr_full **dot_servers = NULL;
size_t n = 0;
CLEANUP_ARRAY(dot_servers, n, in_addr_full_free_array);
@@ -163,7 +163,7 @@ static int link_put_dns(Link *link, OrderedSet **s) {
r = sd_dhcp6_lease_get_dnr(link->dhcp6_lease, &resolvers);
if (r >= 0) {
struct in_addr_full **dot_servers;
struct in_addr_full **dot_servers = NULL;
size_t n = 0;
CLEANUP_ARRAY(dot_servers, n, in_addr_full_free_array);