SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

homework: Remove zeroing of PMBR

Browse Source 
Remove zeroing of PMBR before writing out the new partition table.
There is no reason, to do this explicitly ?
This commit is contained in:
scarlet-storm
2026-02-17 18:23:35 +05:30
parent 2790a782ce
commit a24f11798b
1 changed files with 0 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/home/homework-luks.c
-13
View File
@@ -2856,9 +2856,7 @@ static int apply_resize_partition(
size_t new_partition_size) {
_cleanup_(fdisk_unref_contextp) struct fdisk_context *c = NULL;
_cleanup_free_ void *two_zero_lbas = NULL;
uint32_t ssz;
ssize_t n;
int r;
assert(fd >= 0);
@@ -2873,17 +2871,6 @@ static int apply_resize_partition(
if (r < 0)
return log_error_errno(r, "Failed to determine current sector size: %m");
two_zero_lbas = malloc0(ssz * 2);
if (!two_zero_lbas)
return log_oom();
/* libfdisk appears to get confused by the existing PMBR. Let's explicitly flush it out. */
n = pwrite(fd, two_zero_lbas, ssz * 2, 0);
if (n < 0)
return log_error_errno(errno, "Failed to wipe partition table: %m");
if ((size_t) n != ssz * 2)
return log_error_errno(SYNTHETIC_ERRNO(EIO), "Short write while wiping partition table.");
r = fdisk_new_context_at(fd, /* path= */ NULL, /* read_only= */ false, ssz, &c);
if (r < 0)
return log_error_errno(r, "Failed to open device: %m");