SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

networkd-wwan: handle link_get_by_name() errors in modem_simple_connect()

Browse Source 
modem_simple_connect() ignored the return value of link_get_by_name()
and then checked link for NULL. Since the helper only sets the output
pointer on success, that could read an indeterminate value.

Check and log the return code directly with log_debug_errno().

Co-developed-by: Codex (GPT-5) <noreply@openai.com>
This commit is contained in:
noxiouz
2026-04-08 13:59:32 +02:00
committed by Zbigniew Jędrzejewski-Szmek
parent 34649c6f55
commit b5a1ecb8fc
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/network/networkd-wwan-bus.c
+3 -3
View File
@@ -604,9 +604,9 @@ static void modem_simple_connect(Modem *modem) {
if (!modem->port_name)
return;
(void) link_get_by_name(modem->manager, modem->port_name, &link);
if (!link)
return (void) log_debug("ModemManager: cannot find link for %s", modem->port_name);
r = link_get_by_name(modem->manager, modem->port_name, &link);
if (r < 0)
return (void) log_debug_errno(r, "ModemManager: cannot find link for %s: %m", modem->port_name);
/* Check if .network file found at all */
if (!link->network)