SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test-fs-util: Modernize openat_report_new() test

Browse Source
This commit is contained in:
Daan De Meyer
2024-07-24 18:58:41 +02:00
parent 372e96a5a1
commit b91ad56228
1 changed files with 36 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/test-fs-util.c
+36 -40
View File
@@ -606,71 +606,67 @@ TEST(open_mkdir_at) {
}
TEST(openat_report_new) {
_cleanup_free_ char *j = NULL;
_cleanup_(rm_rf_physical_and_freep) char *d = NULL;
_cleanup_close_ int fd = -EBADF;
_cleanup_(rm_rf_physical_and_freep) char *t = NULL;
_cleanup_close_ int tfd = -EBADF, fd = -EBADF;
bool b;
assert_se(mkdtemp_malloc(NULL, &d) >= 0);
ASSERT_OK((tfd = mkdtemp_open(NULL, 0, &t)));
j = path_join(d, "test");
assert_se(j);
fd = openat_report_new(AT_FDCWD, j, O_RDWR|O_CREAT, 0666, &b);
assert_se(fd >= 0);
fd = openat_report_new(tfd, "test", O_RDWR|O_CREAT, 0666, &b);
ASSERT_OK(fd);
fd = safe_close(fd);
assert_se(b);
ASSERT_TRUE(b);
fd = openat_report_new(AT_FDCWD, j, O_RDWR|O_CREAT, 0666, &b);
assert_se(fd >= 0);
fd = openat_report_new(tfd, "test", O_RDWR|O_CREAT, 0666, &b);
ASSERT_OK(fd);
fd = safe_close(fd);
assert_se(!b);
ASSERT_FALSE(b);
fd = openat_report_new(AT_FDCWD, j, O_RDWR|O_CREAT, 0666, &b);
assert_se(fd >= 0);
fd = openat_report_new(tfd, "test", O_RDWR|O_CREAT, 0666, &b);
ASSERT_OK(fd);
fd = safe_close(fd);
assert_se(!b);
ASSERT_FALSE(b);
assert_se(unlink(j) >= 0);
ASSERT_OK_ERRNO(unlinkat(tfd, "test", 0));
fd = openat_report_new(AT_FDCWD, j, O_RDWR|O_CREAT, 0666, &b);
assert_se(fd >= 0);
fd = openat_report_new(tfd, "test", O_RDWR|O_CREAT, 0666, &b);
ASSERT_OK(fd);
fd = safe_close(fd);
assert_se(b);
ASSERT_TRUE(b);
fd = openat_report_new(AT_FDCWD, j, O_RDWR|O_CREAT, 0666, &b);
assert_se(fd >= 0);
fd = openat_report_new(tfd, "test", O_RDWR|O_CREAT, 0666, &b);
ASSERT_OK(fd);
fd = safe_close(fd);
assert_se(!b);
ASSERT_FALSE(b);
assert_se(unlink(j) >= 0);
ASSERT_OK_ERRNO(unlinkat(tfd, "test", 0));
fd = openat_report_new(AT_FDCWD, j, O_RDWR|O_CREAT, 0666, NULL);
assert_se(fd >= 0);
fd = openat_report_new(tfd, "test", O_RDWR|O_CREAT, 0666, NULL);
ASSERT_OK(fd);
fd = safe_close(fd);
fd = openat_report_new(AT_FDCWD, j, O_RDWR|O_CREAT, 0666, &b);
assert_se(fd >= 0);
fd = openat_report_new(tfd, "test", O_RDWR|O_CREAT, 0666, &b);
ASSERT_OK(fd);
fd = safe_close(fd);
assert_se(!b);
ASSERT_FALSE(b);
fd = openat_report_new(AT_FDCWD, j, O_RDWR, 0666, &b);
assert_se(fd >= 0);
fd = openat_report_new(tfd, "test", O_RDWR, 0666, &b);
ASSERT_OK(fd);
fd = safe_close(fd);
assert_se(!b);
ASSERT_FALSE(b);
fd = openat_report_new(AT_FDCWD, j, O_RDWR|O_CREAT|O_EXCL, 0666, &b);
assert_se(fd == -EEXIST);
fd = openat_report_new(tfd, "test", O_RDWR|O_CREAT|O_EXCL, 0666, &b);
ASSERT_ERROR(fd, EEXIST);
assert_se(unlink(j) >= 0);
ASSERT_OK_ERRNO(unlinkat(tfd, "test", 0));
fd = openat_report_new(AT_FDCWD, j, O_RDWR, 0666, &b);
assert_se(fd == -ENOENT);
fd = openat_report_new(tfd, "test", O_RDWR, 0666, &b);
ASSERT_ERROR(fd, ENOENT);
fd = openat_report_new(AT_FDCWD, j, O_RDWR|O_CREAT|O_EXCL, 0666, &b);
assert_se(fd >= 0);
fd = openat_report_new(tfd, "test", O_RDWR|O_CREAT|O_EXCL, 0666, &b);
ASSERT_OK(fd);
fd = safe_close(fd);
assert_se(b);
ASSERT_TRUE(b);
}
TEST(xopenat_full) {