catalog: don't make catalog_entry_lang() clobber output params on failure

A minor fix to bring this in-line with our coding style
2019-03-07 14:46:35 +01:00
parent faab72d16b
commit bbe804325e
1 changed files with 12 additions and 5 deletions
@@ -209,9 +209,15 @@ int catalog_file_lang(const char* filename, char **lang) {
        return 1;
 }

-static int catalog_entry_lang(const char* filename, int line,
-                              const char* t, const char* deflang, char **lang) {
+static int catalog_entry_lang(
+                const char* filename,
+                unsigned line,
+                const char* t,
+                const char* deflang,
+                char **ret) {
+
        size_t c;
+        char *z;

        c = strlen(t);
        if (c < 2)
@@ -233,10 +239,11 @@ static int catalog_entry_lang(const char* filename, int line,
                                    filename, line);
        }

-        *lang = strdup(t);
-        if (!*lang)
-                        return -ENOMEM;
+        z = strdup(t);
+        if (!z)
+                return -ENOMEM;

+        *ret = z;
        return 0;
 }