resolved-dns-rr: don't leak s if base64_append fails

2021-03-18 13:13:04 +01:00
parent 8f3e1b9d01
commit bc83340176
1 changed files with 3 additions and 3 deletions
@@ -820,8 +820,8 @@ static char *format_txt(DnsTxtItem *first) {
 }

 const char *dns_resource_record_to_string(DnsResourceRecord *rr) {
-        _cleanup_free_ char *t = NULL;
-        char *s, k[DNS_RESOURCE_KEY_STRING_MAX];
+        _cleanup_free_ char *s = NULL, *t = NULL;
+        char k[DNS_RESOURCE_KEY_STRING_MAX];
        int r;

        assert(rr);
@@ -1171,7 +1171,7 @@ const char *dns_resource_record_to_string(DnsResourceRecord *rr) {
        }

        rr->to_string = s;
-        return s;
+        return TAKE_PTR(s);
 }

 ssize_t dns_resource_record_payload(DnsResourceRecord *rr, void **out) {