[PATCH] Build failure - missing linux/limits.h include? · c076a2bde4 - systemd

[PATCH] Build failure - missing linux/limits.h include?

On Tuesday 25 November 2003 00:12, Chris Larson wrote:
> udev fails to compile here unless I'm doing a KLIBC build.  The reason
> appears to be that the normal limits.h in the gcc inc dir doesn't pull
> in linux/limits.h, whereas the limits.h out in the klibc include dirs
> does.  I'd think it'd be best to add a #include <linux/limits.h> to
> udev.h directly, since it uses PATH_MAX.

No, don't include kernel headers directly if you can avoid it.
The problem you are referring to seems to be with old tool chains,
I have the same symptom with my s390 gcc-2.95/glibc-2.1.3.
Including <sys/param.h> instead of <limits.h> seems to fix it.

This commit is contained in:

arnd@arndb.de

2005-04-26 21:13:04 -07:00

committed by

Greg KH

parent 359618cd6e

commit c076a2bde4

1 changed files with 1 additions and 1 deletions

									
										udev.h
									
		+1
		-1
	
												View File
												
				@@ -24,7 +24,7 @@

				#define UDEV_H

				#include "libsysfs/libsysfs.h"

				#include <limits.h>

				#include <sys/param.h>

				#ifdef DEBUG

				#include <syslog.h>