varlink: don't bother replying about validation errors on method calls with 'oneway' set

2023-10-11 18:19:36 +02:00
parent 47c9bbb1ab
commit c270fc448e
1 changed files with 6 additions and 1 deletions
@@ -1314,7 +1314,12 @@ static int varlink_dispatch_method(Varlink *v) {
                        r = varlink_idl_validate_method_call(v->current_method, parameters, &bad_field);
                        if (r < 0) {
                                log_debug_errno(r, "Parameters for method %s() didn't pass validation on field '%s': %m", method, strna(bad_field));
-                                r = varlink_errorb(v, VARLINK_ERROR_INVALID_PARAMETER, JSON_BUILD_OBJECT(JSON_BUILD_PAIR_STRING("parameter", bad_field)));
+
+                                if (!FLAGS_SET(flags, VARLINK_METHOD_ONEWAY)) {
+                                        r = varlink_errorb(v, VARLINK_ERROR_INVALID_PARAMETER, JSON_BUILD_OBJECT(JSON_BUILD_PAIR_STRING("parameter", bad_field)));
+                                        if (r < 0)
+                                                return r;
+                                }
                                invalid = true;
                        }
                }