SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test-copy: Stop using rm_rf_physical_and_close

Browse Source 
This cleanup function depends on resolving fd's to paths via /proc
which is unreliable so we shouldn't depend on it for destructive
operations. Use regular path based cleanup instead.
This commit is contained in:
Daan De Meyer
2022-11-11 10:19:18 +01:00
parent 7d000133c2
commit c9a1202ecb
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/test-copy.c
+4 -3
View File
@@ -77,11 +77,12 @@ TEST(copy_tree_replace_file) {
}
TEST(copy_tree_replace_dirs) {
_cleanup_(rm_rf_physical_and_closep) int src = -1, dst = -1;
_cleanup_(rm_rf_physical_and_freep) char *srcp = NULL, *dstp = NULL;
_cleanup_close_ int src = -1, dst = -1;
/* Create the random source/destination directories */
assert_se((src = mkdtemp_open(NULL, 0, NULL)) >= 0);
assert_se((dst = mkdtemp_open(NULL, 0, NULL)) >= 0);
assert_se((src = mkdtemp_open(NULL, 0, &srcp)) >= 0);
assert_se((dst = mkdtemp_open(NULL, 0, &dstp)) >= 0);
/* Populate some data to differentiate the files. */
assert_se(write_string_file_at(src, "foo", "src file 1", WRITE_STRING_FILE_CREATE) >= 0);