SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tpm2-setup: remove redundant fflush_and_check()

Browse Source 
The immediately following flink_tmpfile() does that anyway, hence no
need to do so explicitly beforehand.

(Also the log message was wrong: it says "sync" but here we "flush",
which is a much weaker operation)
This commit is contained in:
Lennart Poettering
2025-02-26 09:13:37 +01:00
parent f4e5a73000
commit d10d5a0508
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tpm2-setup/tpm2-setup.c
-8
View File
@@ -348,10 +348,6 @@ static int run(int argc, char *argv[]) {
if (fchmod(fileno(f), 0444) < 0)
return log_error_errno(errno, "Failed to adjust access mode of SRK public key file '%s' to 0444: %m", pem_path);
r = fflush_and_check(f);
if (r < 0)
return log_error_errno(r, "Failed to sync SRK key to disk: %m");
r = flink_tmpfile(f, t, pem_path, LINK_TMPFILE_SYNC|LINK_TMPFILE_REPLACE);
if (r < 0)
return log_error_errno(r, "Failed to move SRK public key file to '%s': %m", pem_path);
@@ -382,10 +378,6 @@ static int run(int argc, char *argv[]) {
if (fchmod(fileno(f), 0444) < 0)
return log_error_errno(errno, "Failed to adjust access mode of SRK public key file '%s' to 0444: %m", tpm2b_public_path);
r = fflush_and_check(f);
if (r < 0)
return log_error_errno(r, "Failed to sync SRK key to disk: %m");
r = flink_tmpfile(f, t, tpm2b_public_path, LINK_TMPFILE_SYNC|LINK_TMPFILE_REPLACE);
if (r < 0)
return log_error_errno(r, "Failed to move SRK public key file to '%s': %m", tpm2b_public_path);