SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

machine: fix memleak in vl_method_list_images()

Browse Source 
Fixes an issue in fb0ea6a6a3.
This commit is contained in:
Yu Watanabe
2024-10-15 14:24:58 +09:00
parent d2c1451b73
commit d1ac7d76b4
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/machine/machined-varlink.c
+4 -2
View File
@@ -583,16 +583,18 @@ static int vl_method_list_images(sd_varlink *link, sd_json_variant *parameters,
return r;
if (p.image_name) {
_cleanup_(image_unrefp) Image *found = NULL;
if (!image_name_is_valid(p.image_name))
return sd_varlink_error_invalid_parameter_name(link, "name");
r = image_find(IMAGE_MACHINE, p.image_name, /* root = */ NULL, &image);
r = image_find(IMAGE_MACHINE, p.image_name, /* root = */ NULL, &found);
if (r == -ENOENT)
return sd_varlink_error(link, "io.systemd.MachineImage.NoSuchImage", NULL);
if (r < 0)
return log_debug_errno(r, "Failed to find image: %m");
return list_image_one_and_maybe_read_metadata(link, image, /* more = */ false, p.acquire_metadata);
return list_image_one_and_maybe_read_metadata(link, found, /* more = */ false, p.acquire_metadata);
}
if (!FLAGS_SET(flags, SD_VARLINK_METHOD_MORE))