sysusers: move global variables into a Context object

Browse Source

Our coding style says static variables suck except for very special
cases, i.e. things like the log level or very per-process stuff, such as
parsed version of cmdline args and such. sysusers departed from that as
one of the very few exceptions in our codebases: it keeps its
operational state in global variables.

Address that. Introduce a Context object that carries the fields that so
far have been global, and pass it around as needed.

This has the nice effect that state and configuration is clearly
separated in code, and we can very clearly see which functions mangle
state and which ones do not.

No actual codeflow changes, just refactoring.

...

This commit is contained in:

Lennart Poettering

2023-08-09 17:34:00 +02:00

parent 7a23cc4b66

commit d2a1673713

1 changed files with 269 additions and 176 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

src/sysusers/sysusers.c

+269 -176

File diff suppressed because it is too large Load Diff