image-discover: skip properly over files that cannot be recognized as image files

Follow-up for: #29364
2023-10-05 23:23:31 +01:00
parent c79e760f36
commit e7df707b8a
1 changed files with 6 additions and 5 deletions
@@ -629,13 +629,14 @@ int image_discover(
                                r = extract_pretty(de->d_name, image_class_suffix_to_string(class), NULL, &pretty);
                        else if (S_ISBLK(st.st_mode))
                                r = extract_pretty(de->d_name, NULL, NULL, &pretty);
-                        else
+                        else {
+                                log_debug("Skipping directory entry '%s', which is neither regular file, directory nor block device.", de->d_name);
                                continue;
-                        if (r < 0)
-                                return r;
-
-                        if (!image_name_is_valid(pretty))
+                        }
+                        if (r < 0) {
+                                log_debug_errno(r, "Skipping directory entry '%s', which doesn't look like an image.", de->d_name);
                                continue;
+                        }

                        if (hashmap_contains(h, pretty))
                                continue;