sd-dhcp6-client: Use offsetof() instead of sizeof()
The slightly modified review comments say that "...in theory offsetof(DHCP6Option, data) is nicer than sizeof(DHCP6Option) because the former removes alignment artifacts. In this specific case there are no alignment whitespaces hence it's fine, but out of a matter of principle offsetof() is preferred over sizeof() in cases like this..."
This commit is contained in:
@@ -788,7 +788,8 @@ static int client_parse_message(
|
||||
uint8_t *optval;
|
||||
be32_t iaid_lease;
|
||||
|
||||
if (len < sizeof(DHCP6Option) || len < sizeof(DHCP6Option) + be16toh(option->len))
|
||||
if (len < offsetof(DHCP6Option, data) ||
|
||||
len < offsetof(DHCP6Option, data) + be16toh(option->len))
|
||||
return -ENOBUFS;
|
||||
|
||||
optcode = be16toh(option->code);
|
||||
|
||||
Reference in New Issue
Block a user