SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

udev/net: mention which SR-IOV setting could not be applied in log message

Browse Source
This commit is contained in:
Yu Watanabe
2025-05-05 22:07:04 +09:00
parent fed4da3a19
commit f4282e6a06
1 changed files with 22 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/udev/net/link-config.c
+22 -26
View File
@@ -854,38 +854,32 @@ static int link_generate_alternative_names(Link *link) {
return 0;
}
static int sr_iov_configure(Link *link, sd_netlink **rtnl, SRIOV *sr_iov) {
static int sr_iov_configure(Link *link, sd_netlink **rtnl, SRIOV *sr_iov, SRIOVAttribute attr) {
int r;
assert(link);
assert(rtnl);
assert(link->ifindex > 0);
for (SRIOVAttribute attr = 0; attr < _SR_IOV_ATTRIBUTE_MAX; attr++) {
if (!sr_iov_has_config(sr_iov, attr))
continue;
if (!sr_iov_has_config(sr_iov, attr))
return 0;
if (!*rtnl) {
r = sd_netlink_open(rtnl);
if (r < 0)
return r;
}
_cleanup_(sd_netlink_message_unrefp) sd_netlink_message *req = NULL;
r = sd_rtnl_message_new_link(*rtnl, &req, RTM_SETLINK, link->ifindex);
if (r < 0)
return r;
r = sr_iov_set_netlink_message(sr_iov, attr, req);
if (r < 0)
return r;
r = sd_netlink_call(*rtnl, req, 0, NULL);
if (!*rtnl) {
r = sd_netlink_open(rtnl);
if (r < 0)
return r;
}
return 0;
_cleanup_(sd_netlink_message_unrefp) sd_netlink_message *req = NULL;
r = sd_rtnl_message_new_link(*rtnl, &req, RTM_SETLINK, link->ifindex);
if (r < 0)
return r;
r = sr_iov_set_netlink_message(sr_iov, attr, req);
if (r < 0)
return r;
return sd_netlink_call(*rtnl, req, 0, NULL);
}
static int link_apply_sr_iov_config(Link *link) {
@@ -925,11 +919,13 @@ static int link_apply_sr_iov_config(Link *link) {
continue;
}
r = sr_iov_configure(link, &link->event->rtnl, sr_iov);
if (r < 0)
log_link_warning_errno(link, r,
"Failed to set up SR-IOV virtual function %"PRIu32", ignoring: %m",
sr_iov->vf);
for (SRIOVAttribute attr = 0; attr < _SR_IOV_ATTRIBUTE_MAX; attr++) {
r = sr_iov_configure(link, &link->event->rtnl, sr_iov, attr);
if (r < 0)
log_link_warning_errno(link, r,
"Failed to set up %s for SR-IOV virtual function %"PRIu32", ignoring: %m",
sr_iov_attribute_to_string(attr), sr_iov->vf);
}
}
return 0;