Various small cleanups (#39155)

man/udev_enumerate_new.xml

@@ -52,12 +52,13 @@
   <refsect1>
     <title>Description</title>
 
-    <para><function>udev_enumerate_new()</function> creates an enumeration context to scan /sys.</para>
+    <para><function>udev_enumerate_new()</function> creates an enumeration context to scan
+    <filename>/sys/</filename>.</para>
 
     <para><function>udev_enumerate_ref()</function> takes a reference of an enumeration context.</para>
 
-    <para><function>udev_enumerate_unref()</function> drops a reference of an enumeration context. If the refcount reaches zero,
-    all resources of the enumeration context will be released.</para>
+    <para><function>udev_enumerate_unref()</function> drops a reference of an enumeration context. If the
+    refcount reaches zero, all resources of the enumeration context will be released.</para>
   </refsect1>
 
   <refsect1>

src/core/cgroup.c

@@ -1454,12 +1454,6 @@ static void set_io_weight(Unit *u, uint64_t weight) {
         (void) set_attribute_and_warn(u, "io.weight", buf);
 }
 
-static void cgroup_apply_bpf_foreign_program(Unit *u) {
-        assert(u);
-
-        (void) bpf_foreign_install(u);
-}
-
 static void cgroup_context_apply(
                 Unit *u,
                 CGroupMask apply_mask,
@@ -1609,7 +1603,7 @@ static void cgroup_context_apply(
                 cgroup_apply_firewall(u);
 
         if (apply_mask & CGROUP_MASK_BPF_FOREIGN)
-                cgroup_apply_bpf_foreign_program(u);
+                (void) bpf_foreign_install(u);
 
         if (apply_mask & CGROUP_MASK_BPF_SOCKET_BIND)
                 cgroup_apply_socket_bind(u);

src/core/varlink.c

@@ -425,9 +425,6 @@ static int manager_varlink_init_system(Manager *m) {
 
         assert(m);
 
-        if (!MANAGER_IS_SYSTEM(m))
-                return 0;
-
         r = manager_setup_varlink_server(m);
         if (r < 0)
                 return log_error_errno(r, "Failed to set up varlink server: %m");
@@ -456,9 +453,6 @@ static int manager_varlink_init_user(Manager *m) {
 
         assert(m);
 
-        if (!MANAGER_IS_USER(m))
-                return 0;
-
         if (MANAGER_IS_TEST_RUN(m))
                 return 0;
 

src/shared/generator.c

@@ -161,7 +161,7 @@ static int generator_add_ordering(
         assert(order);
         assert(dst);
 
-        /* Adds in an explicit ordering dependency of type <order> from <src> to <dst>. If <instance> is
+        /* Adds an explicit ordering dependency of type <order> from <src> to <dst>. If <instance> is
          * specified, it is inserted into <dst>. */
 
         if (instance) {

src/ssh-generator/ssh-issue.c

@@ -25,7 +25,7 @@ static enum {
         ACTION_RM_VSOCK,
 } arg_action = ACTION_MAKE_VSOCK;
 
-static char* arg_issue_path = NULL;
+static char *arg_issue_path = NULL;
 static bool arg_issue_stdout = false;
 
 STATIC_DESTRUCTOR_REGISTER(arg_issue_path, freep);