SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
59,882 Commits 2 Branches 1 Tag
1a0281a3ebf4f8c16d40aa9e63103f16cd23bb2a
Commit Graph
59882 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Zbigniew Jędrzejewski-Szmek 1a0281a3eb coredump: shorten output about package metadata to one line 
We would print the whole thing in extenso. Users generally don't care,
and would likely prefer to just get the compact identifier of the package
that they can use in a bug report or package manager commands.

Before:
systemd-coredump[40645]: [🡕] Process 1975 (gnome-shell) of user 1000 dumped core.

                         Module /usr/bin/gnome-shell (deleted) with build-id aafdb7d69a7efca937e490080ad9348541fc57d8
                         Metadata for module /usr/bin/gnome-shell (deleted) owned by FDO found: {
                                 "type" : "rpm",
                                 "name" : "gnome-shell",
                                 "version" : "43~rc-3.fc37",
                                 "architecture" : "x86_64",
                                 "osCpe" : "cpe:/o:fedoraproject:fedora:37"
                         }

                         Module /usr/lib64/gnome-shell/libgvc.so (deleted) with build-id 56cbb9862e1ee84ca1549b94f2b4cda03537613e
                         Metadata for module /usr/lib64/gnome-shell/libgvc.so (deleted) owned by FDO found: {
                                 "type" : "rpm",
                                 "name" : "gnome-shell",
                                 "version" : "43~rc-2.fc37",
                                 "architecture" : "x86_64",
                                 "osCpe" : "cpe:/o:fedoraproject:fedora:37"
                         }

                         Module /usr/lib64/libLLVM-14.so (deleted) with build-id ffa7e43f48eb4c189304c0241b1862710de4c3a4
                         Metadata for module /usr/lib64/libLLVM-14.so (deleted) owned by FDO found: {
                                 "type" : "rpm",
                                 "name" : "gnome-shell",
                                 "version" : "43~rc-2.fc37",
                                 "architecture" : "x86_64",
                                 "osCpe" : "cpe:/o:fedoraproject:fedora:37"
                         }

After:
systemd-coredump[235218]: [🡕] Process 235216 (bash) of user 1000 dumped core.

                          Module libtinfo.so.6 from rpm ncurses-6.3-3.20220501.fc37.x86_64, build-id=71a04d23fd572525eb6efc47026c379725e06d96
                          Module bash from rpm bash-5.1.16-3.fc37.x86_64, build-id=6c936aff95a2ccda04a3fb685a81a84a0a8d10da
                          Stack trace of thread 235216:
                          #0  0x00007fa409ec8d8b kill (libc.so.6 + 0x38d8b)
                          #1  0x0000560d35e366b1 kill_builtin (bash + 0xad6b1)
                          #2  0x0000560d35dd7227 execute_builtin.lto_priv.0 (bash + 0x4e227)
                          #3  0x0000560d35dd0459 execute_simple_command (bash + 0x47459)
                          #4  0x0000560d35dd1de0 execute_command_internal (bash + 0x48de0)
                          #5  0x0000560d35e307aa parse_and_execute (bash + 0xa77aa)
                          #6  0x0000560d35e91b08 run_one_command.isra.0 (bash + 0x108b08)
                          #7  0x0000560d35dba07c main (bash + 0x3107c)
                          #8  0x00007fa409eb3510 __libc_start_call_main (libc.so.6 + 0x23510)
                          #9  0x00007fa409eb35c9 __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x235c9)
                          #10 0x0000560d35dbad85 _start (bash + 0x31d85)
 2022-09-28 10:47:42 +02:00
Zbigniew Jędrzejewski-Szmek 87707784c7 coredump: when parsing json, optionally copy the string first 2022-09-28 09:38:13 +02:00
Daan De Meyer 4f0d1cd011 Merge pull request #24691 from yuwata/udev-node-check-existence 
udev: check existence of device node
 2022-09-18 11:38:56 +02:00
Daan De Meyer a36b572166 Merge pull request #24710 from yuwata/test-50-dissect-cleanups 
TEST-50-DISSECT: cleanups
 2022-09-18 11:21:30 +02:00
Yu Watanabe 0f75b0c589 dissect-image: free crypt_device object before trying to activate with unique name 
Otherwise we get error from libcryptsetup like the following:
systemd[1234]: Cannot use device /dev/loop5 which is in use (already mapped or mounted).
 2022-09-18 11:19:33 +02:00
Yu Watanabe a1c3628b19 udev: downgrade log level when device node is already removed 
Follow-up for 790da548b0.
 2022-09-18 10:51:25 +02:00
Yu Watanabe ea16d7f48e dissect-image: lazily deactivate decrypted DM volumes 
The DM block device may be still used by other processes.
 2022-09-18 07:27:22 +09:00
Lennart Poettering f578c659c4 measure: rename measure_pcr() to measure_kernel() 
Let's say what we actually measure, not what into (which is obvious
anyway).

This is generally more descriptive, but also good for later work that
allows measuring the boot phase too.
 2022-09-18 07:27:00 +09:00
Yu Watanabe cf610e1d87 cryptsetup-util: introduce crypt_free_and_replace() 2022-09-18 04:57:10 +09:00
Lennart Poettering 0ea720ca7e Merge pull request #24622 from yuwata/udev-open-with-noctty 
udev: open with O_NOCTTY
 2022-09-17 19:03:15 +02:00
Zbigniew Jędrzejewski-Szmek eb5b6b7310 Merge pull request #24708 from keszybz/not-available-in-tables 
various: use "-" instead of "n/a" in tables
 2022-09-17 18:16:42 +02:00
Yu Watanabe d3fcb73678 test-50-dissect: do not fail test on cleanup 
These paths are read-only mount points. Hence, we cannot remove the
contents.
 2022-09-17 21:36:18 +09:00
Yu Watanabe 759b4b4a2a test-50-dissect: check mount destination instead of mount source 
And rebreak long lines.

This should take no effective change, just refactoring.
 2022-09-17 21:36:18 +09:00
Zbigniew Jędrzejewski-Szmek 15b3f7e309 Merge pull request #24670 from keszybz/early-boot-ordering 
Early boot ordering
 2022-09-17 13:26:51 +02:00
Zbigniew Jędrzejewski-Szmek 7f8afa6dc1 coredumpctl: rename table entry 
"Disk Size" could be mistaken for "Size of the Disk".
 2022-09-17 13:12:49 +02:00
Zbigniew Jędrzejewski-Szmek 8a9651088f various: use "-" instead of "n/a" in tables 
In the context of a table, both would be generally understood to have the same
meaning. "n/a" is a strange beast. It was useful when tables were produced on
the typewriter with "---------" used to separate rows. It is visually more
pleasing to use "-", and there is no risk of it being mistaken for a row
separator.
 2022-09-17 13:05:51 +02:00
Daan De Meyer 9bf36477bf Merge pull request #24703 from yuwata/dissect-image-verity-partition-make-fail 
dissect-image: make verity_partition() actually fail when all attempts of activation failed
 2022-09-17 09:57:20 +02:00
Yu Watanabe ee3455cf11 fd-util: rename CLOSE_AND_REPLACE() -> close_and_replace() 
We have free_and_replace() and friends, they are all named with lower
letters, even they are macros, not functions.
For consistency, let's rename CLOSE_AND_REPLACE() with lower letters.

This also mekes the macro used more places.
 2022-09-17 09:54:41 +02:00
Yu Watanabe 9972e6d6ed dissect-image: make verity_partition() actually fail when all attempts of activation failed 2022-09-17 05:18:25 +09:00
Yu Watanabe ad361a50fb dissect-image: split out verity_timeout() 
To make verity_partition() shorten. No functional changes, just
refactoring.
 2022-09-17 05:18:25 +09:00
Yu Watanabe cb19517490 man: explicitly document that "reboot -f" is different from "systemctl reboot -f" 
Closes #24696.
 2022-09-17 05:15:36 +09:00
Lennart Poettering c941b65075 nspawn: fix two error strings 2022-09-17 05:15:02 +09:00
Dan Streetman 137d162c42 add CAP_LINUX_IMMUTABLE to systemd-machined, so it can handle machinectl read-only requests 
Without this, the 'machinectl read-only ...' command always fails.
 2022-09-16 19:50:52 +01:00
Yu Watanabe dd35a61caf sd-netlink: unexport sd-netlink 
This effectively reverts 84e1001541.

The sd-netlink library has several issues, and we should not export it
without solving them. See issues #24258 and #24124.
 2022-09-17 01:31:57 +09:00
Yu Watanabe 54ee1cd69d Merge pull request #24692 from yuwata/dissect-image-fix-memleak 
dissect-image: fix memleak
 2022-09-17 01:31:32 +09:00
Lennart Poettering d52e1c81b9 update TODO 
Seeding RNG via SMBIOS is bad idea, since often measurement of SMBIOS
tables is used for TPM policies, under the assumption SMBIOS remains
static after a certain point.
 2022-09-16 16:24:56 +01:00
Lennart Poettering c5be1ceb08 tmpfiles: let's suffix path to dirs with '/' also in log messages 2022-09-17 00:20:24 +09:00
Lennart Poettering 0af7e6ee73 tmpfiles: drop redundant forward declarations 2022-09-17 00:20:10 +09:00
Yu Watanabe ab8e6464b5 Merge pull request #24664 from yuwata/watchdog 
watchdog: open /dev/watchdog0 only if it exists
 2022-09-17 00:18:53 +09:00
Yu Watanabe e99b370ccb Merge pull request #24688 from yuwata/watchdog-dbus-properties-follow-ups 
pid1: follow-ups for watchdog DBus properties
 2022-09-17 00:18:05 +09:00
Daniel Braunwarth 43deb1a8dc journalctl: respect --quiet flag during file concistency verification 
Fixes #24563.
 2022-09-17 00:17:47 +09:00
Yu Watanabe e9fe11090e Merge pull request #24685 from yuwata/uid-range 
uid-range: several cleanups
 2022-09-17 00:16:07 +09:00
Yu Watanabe 5bf5013fc9 dissect-image: handle all non-negative return values as success 
No functional changes, just coding syle update.
 2022-09-16 23:11:09 +09:00
Yu Watanabe 041e2edac8 dissect-image: fix memleak on failure 2022-09-16 23:11:09 +09:00
Yu Watanabe 69928b4f15 udev-node: do not create symlink to a non-existing device node 
Previously, the stack directory contains empty regular files named with
device ID, and we create sd_device object from the device name.
Hence, we implicitly checked the existence of the device node.

However, now the files in the stack directory are symlink, and we
retrieve the path to the device node and its priority from the symlink.
Hence, the existence of the device node is not checked.
Let's check if the device node is still exist.
 2022-09-16 23:08:07 +09:00
Yu Watanabe 13271e2dde udev-node: split out stack_directory_read_one() 
No functional changes, just refactoring.
 2022-09-16 23:07:31 +09:00
Yu Watanabe a6b7ebaafa watchdog: use /dev/watchdog0 only if it exists 
Fixes #24661.
 2022-09-16 22:34:37 +09:00
Lennart Poettering 72a773775d update TODO 2022-09-16 13:57:05 +01:00
Yu Watanabe 3e911a0d0e pid1: drop redundant DBus properties 
Follow-up for 10f3f4ed01.

We already have RuntimeWatchdogUSec or friends. Let's not introduce
redundant properties.

Also, drop the const qualifier for WatchdogLastPingTimestamp, as they
are actually not constant.
 2022-09-16 21:53:28 +09:00
Yu Watanabe 9341f41801 watchdog: explicitly initialize global variable 
No functional change, as they were implicitly initialized with zero.
 2022-09-16 21:48:39 +09:00
Yu Watanabe 269073fda6 test: add tests for uid_range_coalesce() 2022-09-16 21:11:19 +09:00
Yu Watanabe 8dcc66cefc uid-range: tie up number and array of uid range entries 
This renames UidRange -> UidRangeEntry, and reintroduces UidRange which
contains the array of UidRangeEntry and its size.
No fucntional changes, just refactoring.
 2022-09-16 20:56:58 +09:00
Yu Watanabe 6cc6cd9289 uid-range: make uid_range_intersect() take two UidRange objects 
No functional changes, just refactoring.
 2022-09-16 20:52:47 +09:00
Yu Watanabe f6c13f9f95 uid-range: optimize to load uid_map file 
If uid_map contains many lines, then the previous logic takes O(n^2 log n),
This makes O(n log n).
 2022-09-16 20:52:36 +09:00
Yu Watanabe b5739767da uid-range: escape from loop earlier 
The array of uid range entries are already sorted. Hence, if x and y are
does not have intersection, then the remaining entries neither have
intersection with x.
 2022-09-16 20:50:00 +09:00
Yu Watanabe 34eeba475d uid-range: sort uid range entries in uid_range_coalesce() 
As the logic in uid_range_coalesce() assumes the array of entries are
already sorted.
No functional changes, just refactoring.
 2022-09-16 20:49:55 +09:00
Yu Watanabe 7cf337c50f uid-range: use parse_uid_range() 2022-09-16 20:48:53 +09:00
Yu Watanabe fb76e6a710 userdbctl: fix arrow direction 2022-09-16 20:48:53 +09:00
Yu Watanabe 3498609f08 userdbctl: do not show meaningless boundaries when no uid range available 2022-09-16 20:48:53 +09:00
Yu Watanabe f91c23f785 sd-device-monitor: do not trigger assertion when uid_map is not empty 
Follow-up for c0aa23cf1e.
 2022-09-16 13:05:51 +02:00