Yu Watanabe
3da3cdd592
resolve: drop unused argument of dns_server_packet_lost()
2018-06-13 13:20:23 +09:00
Yu Watanabe
eab39da1fa
resolve: correctly count TCP transaction failures
...
Fixes #9281 .
2018-06-13 13:13:40 +09:00
Yu Watanabe
3c0dcbcf4f
resolve: fix log message
2018-06-13 12:21:54 +09:00
Yu Watanabe
1a363edad1
bash-completion/resolvectl: support privatedns command
2018-06-13 11:16:26 +09:00
Yu Watanabe
ddf1a95301
resolve: reject PrivateDNS=yes
2018-06-13 11:00:52 +09:00
Yu Watanabe
8adbd86586
resolve: make manager_get_private_dns_mode() always return valid setting
2018-06-13 11:00:28 +09:00
Yu Watanabe
b761a10797
resolve: add missing bus property and method
...
Follow-up for #8849 .
2018-06-13 10:50:34 +09:00
Yu Watanabe
b474ff59e6
fuzz: add testcase for issue 8827
2018-06-11 12:39:59 +09:00
Yu Watanabe
1c73b60b4d
util-lib: reject too long path for timedate_is_valid()
...
This should fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=8827 .
2018-06-11 12:38:34 +09:00
Yu Watanabe
60091993a9
locale: add _unused_ attribute for dummy variable
...
This suppresses the following warning by clang:
```
[588/1179] Compiling C object 'systemd-localed@exe/src_locale_localed.c.o'.
../src/locale/localed.c:271:39: warning: unused variable 'dummy' [-Wunused-variable]
_cleanup_(locale_free) char **dummy = new_locale;
^
```
2018-06-06 12:27:52 +02:00
Yu Watanabe
c0d72c4313
conf-parser: fix memleak ( #9177 )
...
Fixes CID#1391437.
Closes #9180 .
2018-06-04 15:18:28 +03:00
Yu Watanabe
a6dffbb7e7
test: fix function name
2018-06-04 09:33:45 +02:00
Yu Watanabe
d3c8afd092
man: RuntimeDirectory= or friends accept dot contained paths
2018-06-04 01:44:04 +09:00
Yu Watanabe
f106314c89
conf-parser: remove redundant utf8-validity check
2018-06-04 01:38:54 +09:00
Yu Watanabe
97b9c506cf
conf-parse: use free_and_replace()
...
Also removes unnecessary empty lines.
2018-06-04 00:30:42 +09:00
Yu Watanabe
78d17fa099
conf-parser: reject utf8-invalid lines
2018-06-04 00:30:18 +09:00
Yu Watanabe
2b633119a0
test: add test for trailing dot in WorkingDirectory= and RuntimeDirectory=
2018-06-03 23:59:51 +09:00
Yu Watanabe
2f4d31c117
load-fragment: use path_simplify_and_warn() where applicable
2018-06-03 23:59:42 +09:00
Yu Watanabe
cd4f53c5b5
conf-parse: use path_simplify_and_warn() in config_parse_path()
2018-06-03 23:57:30 +09:00
Yu Watanabe
58a53adde5
path-util: introduce path_simplify_and_warn()
2018-06-03 23:54:55 +09:00
Yu Watanabe
4805426279
path-util: make path_make_relative() support path including dots
2018-06-03 23:54:32 +09:00
Yu Watanabe
858d36c1ec
path-util: introduce path_simplify()
...
The function is similar to path_kill_slashes() but also removes
initial './', trailing '/.', and '/./' in the path.
When the second argument of path_simplify() is false, then it
behaves as the same as path_kill_slashes(). Hence, this also
replaces path_kill_slashes() with path_simplify().
2018-06-03 23:39:26 +09:00
Yu Watanabe
40352cf0c1
netdev: fix parser for VRF.Table=
...
This effectively reverts f98dd1e707 (#6704 ).
Fixes #9150 .
2018-06-02 11:15:37 +02:00
Yu Watanabe
4156e767f6
locale: assume locale is for LANG= when variable name is not specified
...
Closes #6070 .
2018-05-31 17:57:41 +09:00
Yu Watanabe
b613b01920
doc: update TODO
2018-05-31 17:39:13 +09:00
Yu Watanabe
33ab22fcb9
man: mention that systemd-sysusers understand the specifier.
2018-05-31 17:37:57 +09:00
Yu Watanabe
b8bed70068
sysusers: support specifier expansion for GECOS and home directory fields
2018-05-31 17:36:22 +09:00
Yu Watanabe
df4fd2c757
locale: re-read configuration files if changed
...
Closes #8491 .
2018-05-31 16:24:45 +09:00
Yu Watanabe
6a837b035f
locale: use _cleanup_free_ and free_and_replace
2018-05-31 16:17:18 +09:00
Yu Watanabe
fe28d88746
locale: check xkb data before requesting authentication
2018-05-31 16:16:25 +09:00
Yu Watanabe
b47ff73b18
locale: return earlier if no operation will be done
2018-05-31 16:15:21 +09:00
Yu Watanabe
17ee3d72da
load-fragment: use free_and_replace()
2018-05-31 13:27:06 +09:00
Yu Watanabe
3c381a671f
load-fragment: add missing oom check
...
Fixes CID#1391379.
2018-05-31 13:26:27 +09:00
Yu Watanabe
66c9dfdddc
portable: fix memleak
...
Fixes CID#1391382.
2018-05-31 13:16:51 +09:00
Yu Watanabe
7be9df7d4a
core/socket: fix coding style
2018-05-31 11:09:41 +09:00
Yu Watanabe
535775805a
load-fragment: move macro-defined config parsers
2018-05-31 11:09:41 +09:00
Yu Watanabe
984faf29da
load-fragment: use DEFINE_CONFIG_PARSE_*() macros
2018-05-31 11:09:41 +09:00
Yu Watanabe
e405b67d23
load-fragment: make IPTOS= accept the empty string
2018-05-31 11:09:41 +09:00
Yu Watanabe
00463fbf0d
load-fragment: make SocketProtocol= accept the empty string
2018-05-31 11:09:41 +09:00
Yu Watanabe
fa65c28176
namespace: rename parse_protect_{home,system}_or_bool() to protect_{home,system}_or_bool_to_string()
...
Hence, we can define config_parse_protect_{home,system}() by using
DEFINE_CONFIG_PARSE_ENUM() macro.
2018-05-31 11:09:41 +09:00
Yu Watanabe
b54e98ef8e
socket-util: rename parse_socket_address_bind_ipv6_only_or_bool() to socket_address_bind_ipv6_only_or_bool_from_string()
...
Hence, we can define config_parse_socket_bind() by using
DEFINE_CONFIG_PARSE_ENUM() macro.
2018-05-31 11:09:41 +09:00
Yu Watanabe
2d1729ca3f
conf-parser: introduce DEFINE_CONFIG_PARSE*() macros
...
This introduces several macros for defining config parsers.
Also this fixes errno in DEFINE_CONFIG_PARSE_ENUM() and _ENUMV()
and makes the log level lower when a duplicated item is
specified to the settings parsed by the function defined by
DEFINE_CONFIG_PARSE_ENUMV().
2018-05-31 11:09:41 +09:00
Yu Watanabe
0a9e363870
load-fragment: drop config_parse_no_new_privileges() and use config_parse_bool() instead
2018-05-31 11:09:41 +09:00
Yu Watanabe
862fcffd9c
load-fragment: make WorkingDirectory= accept the empty string
2018-05-31 11:09:41 +09:00
Yu Watanabe
fb27be3f60
load-fragment: use parse_sec_fix_0() instead of updating the value later
2018-05-31 11:09:41 +09:00
Yu Watanabe
6c58305ac3
load-fragment: use config_parse_sec_fix_0() for TimeoutStopSec=
2018-05-31 11:09:41 +09:00
Yu Watanabe
71e270150f
load-fragment: always include config_parse_warn_compat() in the table used by unit_dump_config_items()
2018-05-31 11:09:41 +09:00
Yu Watanabe
47544ea1cb
load-fragment: drop unused function config_parse_sysv_priority()
2018-05-31 11:09:41 +09:00
Yu Watanabe
b00e1a9e2a
load-fragment: make CPUSchedulingPolicy= accept the empty string
2018-05-31 11:09:41 +09:00
Yu Watanabe
617d253afa
load-fragment: make IOScheduling{Class,Priority}= accept the empty string
2018-05-31 11:09:41 +09:00
Yu Watanabe
de5e6038ca
load-fragment: setting empty string to Nice= resets the previous assignments
2018-05-31 11:09:41 +09:00
Yu Watanabe
b014b3a524
Merge pull request #9120 from poettering/timedated-timezone-minifixes
...
Minor improvements to timedated
2018-05-30 12:56:23 +09:00
Yu Watanabe
ead6bd250d
tree-wide: fix typo in comments and NEWS
2018-05-29 20:18:45 +02:00
Yu Watanabe
e0eee47707
doc: mention RestrictNamespaces= merges multiple assignment now
...
Follow-up for #8817 .
2018-05-29 09:11:09 +02:00
Yu Watanabe
c2b67dc673
man: use IMAGE for portable service image name
2018-05-28 18:16:32 +09:00
Yu Watanabe
37e21077a3
bash-completion: add completion for portablectl
2018-05-28 18:15:06 +09:00
Yu Watanabe
aea447c9f8
bash-completion: also suggest template unit files
...
Fixes #9041 .
2018-05-28 18:15:00 +09:00
Yu Watanabe
4f150c407f
bash-completion: suggest bus properties instead of configuration items for 'systemctl -p'
...
Closes #5137 .
2018-05-28 18:13:52 +09:00
Yu Watanabe
bbc1acaba0
core: add --dump-bus-properties option to systemd
...
If systemd is invoked with this option, this dumps all bus properties.
This may be useful for shell completion for `systemctl --property`.
2018-05-28 18:13:19 +09:00
Yu Watanabe
95c2b1b0e3
po: update japanese translation
2018-05-28 08:21:51 +02:00
Yu Watanabe
19e69a9c7a
core: include sd-bus-vtable.h in dbus-*.h
2018-05-28 13:36:35 +09:00
Yu Watanabe
2b12ceccd8
Merge pull request #9092 from keszybz/sd-bus-cleanup-more
...
sd-bus: use _cleanup_ more
2018-05-28 10:38:54 +09:00
Yu Watanabe
8d93d7d84b
portablectl: fix memleaks
...
Fixes #9089 .
2018-05-26 16:57:02 +02:00
Yu Watanabe
c5a935b018
portable: fix memleak
...
Closes #9086 .
2018-05-26 16:57:02 +02:00
Yu Watanabe
c1a1b409ce
tree-wide: drop unused variables
...
Follow-ups for #8620 .
2018-05-25 11:33:28 +02:00
Yu Watanabe
37c56f89d2
core: setup mount namespace when RootDirectory= and RuntimeDirectory= or friends are set
...
The directories specified by RuntimeDirectory= or friends are created
on host. So, it is necessary to bind-mount them on root directory.
2018-05-25 17:33:03 +09:00
Yu Watanabe
5609f6888b
core: make StateDirectory= or friends works with DynamicUser= and RootDirectory=/RootImage=
...
The symbolic links to private directories specified by StateDirectory=
or its friends are created on the host. So, when DynamicUser= and
RootDirectory=/RootImage= are set, then the executed process cannot
access private directory.
This makes the private directories are mounted on the non-private place
when both DynamicUser= and RootDirectory=/RootImage= are set.
Fixes #8965 .
2018-05-25 17:25:17 +09:00
Yu Watanabe
6e2d744b2f
doc: mention in NEWS that AF_INET{,6} are dropped from logind
...
Closes #9072 .
2018-05-24 12:05:54 +02:00
Yu Watanabe
d4e9e574ea
network: set DynamicUser= to systemd-networkd.service
2018-05-22 22:37:34 +09:00
Yu Watanabe
0187368cad
resolve: enable DynamicUser= for systemd-resolved.service
2018-05-22 22:32:25 +09:00
Yu Watanabe
fdff1da299
core: chown RuntimeDirectory= if DynamicUser= is set
...
When DynamicUser= is set, then RuntimeDirectory= should be always
chowned, as the service unit may enable RuntimeDirectoryPreserve=,
and the uid or gid may changed from the last run.
This also makes easier to migrate the service to use DynamicUser=.
2018-05-22 22:26:22 +09:00
Yu Watanabe
906cb2eb74
timesync,shared: move logic requesting bus name to shared
...
Preparation for setting DynamicUser= to other services which
request bus names.
2018-05-22 22:20:17 +09:00
Yu Watanabe
be80154827
unit: drop After=systemd-sysusers.service from timesyncd
...
After=systemd-sysusers.service is not necessary, as timesyncd
already enables DynamicUser=.
2018-05-22 22:20:17 +09:00
Yu Watanabe
0297f67e7a
Merge pull request #9036 from keszybz/rpm-macro-cleanup
...
rpm macro cleanup
2018-05-20 23:20:24 +09:00
Yu Watanabe
c9f620bfec
core: support unit specifiers in IODeviceWeight= and friends
2018-05-20 23:08:50 +09:00
Yu Watanabe
063c4b1a92
core/load-fragment: update log messages
2018-05-20 23:08:29 +09:00
Yu Watanabe
5e2d3a5496
core: use free_and_replace()
2018-05-18 17:35:23 +09:00
Yu Watanabe
e760d687dc
core: fix coding style
2018-05-18 17:34:59 +09:00
Yu Watanabe
8994a11790
core: refuse StateDirectory=private
...
Follow-up for e886568873 (#9021 ).
2018-05-18 13:30:21 +09:00
Yu Watanabe
e610ac3d50
timedatectl: do not wrap polkit policy message
...
If messages are wrapped, then only the last line is shown in the
dialog, at least polkit gui for Xfce. It may be a bug of polkit or
Xfce. But it is not necessary to wrap the message in the policy
file. So, let's fix them.
2018-05-18 00:03:15 +09:00
Yu Watanabe
a8f2b6912e
core: systemd1.manage-unit-files policy implies systemd1.manage-units
...
This makes e.g. `systemctl enable --now` ask password only once.
Follow-up for b07abe63d3abf03df559f7cb2c9863943df22274.
2018-05-18 00:02:58 +09:00
Yu Watanabe
51b66c7a8a
core: systemd1.manage-unit-files policy implies systemd1.reload-daemon
...
Closes #5013 .
2018-05-15 15:01:05 -07:00
Yu Watanabe
14f7edb094
core/dbus-unit: do not pass whole Unit object
2018-05-15 23:11:26 +09:00
Yu Watanabe
874bd264a0
core/dbus-unit: introduce unit_can_{start,stop,isolate}_refuse_manual() functions
2018-05-15 23:11:20 +09:00
Yu Watanabe
92c23c5a70
core: use BUS_DEFINE_PROPERTY_GET* macros
2018-05-15 23:11:16 +09:00
Yu Watanabe
74c308ae44
machine: use BUS_DEFINE_PROPERTY_GET* macros
2018-05-15 23:10:49 +09:00
Yu Watanabe
acd380c450
resolve: use BUS_DEFINE_PROPERTY_GET* macros
2018-05-15 23:07:02 +09:00
Yu Watanabe
6cc379b573
timedate: use BUS_DEFINE_PROPERTY_GET* macros
2018-05-15 23:07:02 +09:00
Yu Watanabe
62cf085143
timesync: use NULL instead of empty string
2018-05-15 23:07:02 +09:00
Yu Watanabe
01adcd691d
login: use BUS_DEFINE_PROPERTY_GET* macros
2018-05-15 23:07:02 +09:00
Yu Watanabe
c321885489
bus-util: add more macros for defining functions of getting dbus properties
2018-05-15 23:07:02 +09:00
Yu Watanabe
539a68e0fb
timedate: do not copy input string before bus_verify_polkit_async()
...
This fixes the commit 2c3def6214 which
breaks `timedatectl set-timezone` called by non-privileged user.
2018-05-15 22:53:42 +09:00
Yu Watanabe
c650f20721
hostname: use free_and_strdup()
...
Also, this makes hostnamed check the input strings before
bus_verify_polkit_async().
2018-05-15 22:51:57 +09:00
Yu Watanabe
5ed29cab4a
sysusers: drop an unused variable
...
Follow-up for ec0327d69c .
2018-05-15 14:04:43 +02:00
Yu Watanabe
d231d569d8
bash-completion: add missing options and commands of timedatectl
...
Follow-up for 6129ec852e .
2018-05-15 10:52:45 +02:00
Yu Watanabe
3ecdd18f87
test: use _cleanup_hashmap_free_ instread of _cleanup_(hashmap_freep)
2018-05-14 14:14:17 +09:00
Yu Watanabe
af4fa99d6a
core: use _cleanup_set_free_ instread of _cleanup_(set_freep)
2018-05-14 14:13:57 +09:00
Yu Watanabe
1ab436e314
sd-bus: use free_and_strdup()
2018-05-14 14:09:03 +09:00
Yu Watanabe
b5340a296c
man: drop a trailing space
2018-05-13 18:44:25 +02:00
Yu Watanabe
b4152e9be1
test: add tests for unit_name_from_dbus_path()
2018-05-13 18:44:25 +02:00