SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
61,445 Commits 2 Branches 1 Tag
494ef1674334bfb3b4b574cb24d447bc4e7986ab
Commit Graph
61445 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Yu Watanabe 494ef16743 resolve: drop recursion in TXT field handling 
Fixes #25683.
 2022-12-10 10:32:09 +09:00
Daan De Meyer 52c602d4c6 ci: Labeler improvements 
- Mention "/please-review" in the contributing guide
- Remove "needs-rebase" on push
- Don't add "please-review" if a green label is set
- Don't add please-review label to draft PRs
- Add please-review when a PR moves out of draft
 2022-12-09 15:37:43 +01:00
Zbigniew Jędrzejewski-Szmek 7aebbdcfa9 Merge pull request #25636 from thom311/th/wcast-align-fixes 
all: avoid various "-Wcast-align=strict" warnings
 2022-12-09 15:03:45 +01:00
Thomas Haller 6759b62720 all: avoid various "-Wcast-align=strict" warnings 2022-12-09 08:58:07 +01:00
Zbigniew Jędrzejewski-Szmek 7b37aea98c Merge pull request #25653 from yuwata/base64_append 
hexdecoct: several fixes for base64_append()
 2022-12-08 21:22:32 +01:00
Yu Watanabe 029a7f5a0e fuzz: shorten filename of testcase 
Follow-up for 46dc071985 and
76519cecc7.
 2022-12-09 05:01:04 +09:00
Yu Watanabe b9152f2d63 resolve: optimize conversion of TXT fields to json 
Fixes oss-fuzz#54080 (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=54080).

Fixes #25654.
 2022-12-09 04:59:49 +09:00
Yu Watanabe 7d34567444 hexdecoct: fix NULL pointer dereferences in hexmem() 
Fixes oss-fuzz#54090 (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=54090).

Fixes #25655.
 2022-12-09 04:55:47 +09:00
Yu Watanabe 45655e776f hexdecoct: add missing NULL check 
Fixes oss-fuzz#54065 (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=54065).

Fixes #25650.
 2022-12-09 04:54:43 +09:00
Yu Watanabe 6b0df52e58 test: add tests for base64_append() 2022-12-09 04:53:50 +09:00
Yu Watanabe c21b316964 hexdecoct: several cleanups for base64_append() 
- add missing assertions,
- use size_t for buffser size or memory index,
- handle empty input more gracefully,
- return the length or the result string,
- fix off-by-one issue when the prefix is already long enough.
 2022-12-09 04:53:50 +09:00
Edson Juliano Drosdeck 1feb9743d0 hwdb: add Positivo-vaio Pro PW key toggle touchpad (#25669) 2022-12-09 04:51:09 +09:00
Daan De Meyer 8fc78e6845 ci: Add/Drop labels on pull request activity and comment 
When a pull request is opened/updated, add "please-review" and
remove a few other labels.

When a comment is made with /please-review on a PR. Add the
"please-review" label to the PR.
 2022-12-09 04:50:13 +09:00
Lennart Poettering b6256af75e socket-util: add CMSG_TYPED_DATA() as type-safe wrapper around CMSG_DATA() 2022-12-08 17:48:34 +01:00
Thomas Haller 86bdf11714 fundamental: add CAST_ALIGN_PTR() macro 2022-12-08 17:34:20 +01:00
Lennart Poettering d20ea2c515 Merge pull request #25662 from msizanoen1/s2h-nosuspend-user-proc 
sleep: always thaw user.slice even if freezing failed
 2022-12-08 17:24:52 +01:00
Lennart Poettering 93c1baa0c8 Merge pull request #25667 from poettering/sha256-align-fix 
sha256 alignment fixes/rework
 2022-12-08 17:24:17 +01:00
Lennart Poettering 39a72c13b8 Merge pull request #25665 from poettering/dissect-memory 
dissect: add a mode for operating on an in-memory copy of a DDI, inst…
 2022-12-08 17:23:15 +01:00
Yu Watanabe 340bc268c8 fs-util: make chmod_and_chown_at() work with empty path and AT_FDCWD 
Follow-up for 7d000133c2.

Fixes CID#1500608.
 2022-12-08 15:57:33 +01:00
Lennart Poettering a0ccc18e89 sha256: port to new generic IS_ALIGNED32() macro 
This drops the special casing for s390 and other archs, which was
cargo-culted from glibc. Given it's not obvious why it exists, and is at
best an optimization let's simply avoid it, in particular as the archs
are relatively non-mainstream.

Inspired by: #25636
 2022-12-08 15:30:41 +01:00
Lennart Poettering 4f07388360 macro: add generic IS_ALIGNED32() anf friends 
Let's generalize (and invert) the UNALIGNED32_P() macro from the sha256
code, and let's add a test for it.
 2022-12-08 15:30:31 +01:00
Lennart Poettering 22e339761b sha256: move to unaligned_write_ne32() 2022-12-08 15:18:47 +01:00
Lennart Poettering d8007e7aac fundamental: split out unaligned_{read|write}_ne{16,32,64}() helpers into unaligned-fundamental.h 
Let's allow using this in code shared between userspace and EFI mode.

Also, don't implement these functions via endianness conversions given
we don't actually want to convert endianess here.
 2022-12-08 15:18:47 +01:00
Lennart Poettering 17b296a118 sha256: external headers should be included with <> 2022-12-08 15:18:46 +01:00
Lennart Poettering a579990277 Merge pull request #25180 from keszybz/ukify 
ukify: add helper to create UKIs
 2022-12-08 15:11:18 +01:00
msizanoen1 af1e336589 core: pending_freezer_{message => invocation} 
Rename the field to reflect the new semantics.
 2022-12-08 12:58:00 +01:00
msizanoen1 432a321175 core/sleep: set timeout for freeze/thaw operation to 1.5 seconds 
A FreezeUnit operation can hang due to the presence of kernel threads
(see last 2 commits). Keeping the default configuration will mean the
system will hang for 25 seconds in suspend waiting for the response. 1.5
seconds should be sufficient for most cases.
 2022-12-08 12:58:00 +01:00
msizanoen1 7fcd269784 core/cgroup: ignore kernel cgroup.events when thawing 
The `frozen` state can be `0` while the processes are indeed frozen (see
last commit). Therefore do not respect cgroup.events when checking
whether thawing is necessary.
 2022-12-08 12:58:00 +01:00
Lennart Poettering 971d83a8d3 test: add simple test for new --in-memory switch for systemd-dissect 2022-12-08 12:49:50 +01:00
Lennart Poettering e7e2fbdd60 man: add doc for new --in-memory switch of systemd-dissect 2022-12-08 12:49:50 +01:00
Lennart Poettering 6c07d57075 dissect: add a mode for operating on an in-memory copy of a DDI, instead of directly on it 
This is useful for operating in ephemeral, writable mode on any image,
including read-only ones. It also has the benefit of not keeping the
image file's filesystem busy.

Inspired by the discussions in #25648
 2022-12-08 12:48:06 +01:00
Lennart Poettering fcd8a19da8 loop-util: add new loop_device_make_by_path_memory() helper 
This uses the new memfd_clone_fd() call to make an in-memory copy of
some file before setting up a loopback block device on it.
 2022-12-08 12:47:28 +01:00
Lennart Poettering 6bea3d8e0f data-fd-util: add new memfd_clone_fd() helper 
This adds a new helper for cloning any file's contents (or block device contents) into a new memfd.
 2022-12-08 12:47:01 +01:00
Antonio Alvarez Feijoo 0254e4d66a cryptsetup: retry TPM2 unseal operation if it fails with TPM2_RC_PCR_CHANGED 
Quoting "Trusted Platform Module Library - Part 3: Commands (Rev. 01.59)":

"pcrUpdateCounter – this parameter is updated by TPM2_PolicyPCR(). This value
may only be set once during a policy. Each time TPM2_PolicyPCR() executes, it
checks to see if policySession->pcrUpdateCounter has its default state,
indicating that this is the first TPM2_PolicyPCR(). If it has its default value,
then policySession->pcrUpdateCounter is set to the current value of
pcrUpdateCounter. If policySession->pcrUpdateCounter does not have its default
value and its value is not the same as pcrUpdateCounter, the TPM shall return
TPM_RC_PCR_CHANGED.

If this parameter and pcrUpdateCounter are not the same, it indicates that PCR
have changed since checked by the previous TPM2_PolicyPCR(). Since they have
changed, the previous PCR validation is no longer valid."

The TPM will return TPM_RC_PCR_CHANGED if any PCR value changes (no matter
which) between validating the PCRs binded to the enrollment and unsealing the
HMAC key, so this patch adds a retry mechanism in this case.

Fixes #24906
 2022-12-08 10:37:28 +01:00
Yu Watanabe 15f330cf87 man: mention that DefaultRouteOnDevice= create the IPv4 default route 
And add an example setting for creating an IPv6 default route.

Closes #25440.
 2022-12-08 10:26:26 +01:00
Yu Watanabe 2e83783030 Merge pull request #25672 from jelly/FirwmwareName 
Extend hostnamed DMI firmware properties
 2022-12-08 16:04:36 +09:00
Yu Watanabe daff9d5460 Merge pull request #25564 from poettering/dissect-discover 
systemd-dissect: add simple "--discover" command
 2022-12-08 12:29:07 +09:00
Yu Watanabe cc488e9ba8 Merge pull request #25666 from poettering/selinux-getconf-fixup 
selinux getXYZcon() NULL return fixes
 2022-12-08 12:23:29 +09:00
Jade Lovelace 3b703840d9 oomd: print dry run output at INFO level 
Otherwise, the dry run isn't much use since it would be logged at debug
and not seen.
 2022-12-08 09:26:57 +09:00
Frantisek Sumsal 5dd34c2604 test: wait for the monitoring service to become active 
Otherwise we might start querying resolved too early, causing the
monitoring service to miss stuff:

```
[ 1103.149474] testsuite-75.sh[35]: + systemd-run -u resmontest.service -p Type=notify resolvectl monitor
[ 1103.353803] testsuite-75.sh[423]: Running as unit: resmontest.service
[ 1103.353989] testsuite-75.sh[35]: + knotc zone-begin test.
[ 1103.354160] testsuite-75.sh[425]: OK
...
[ 1103.355298] testsuite-75.sh[35]: + knotc reload
[ 1103.355363] testsuite-75.sh[438]: Reloaded
[ 1103.355536] testsuite-75.sh[35]: + : '--- nss-resolve/nss-myhostname tests'
[ 1103.355536] testsuite-75.sh[35]: + run getent -s resolve hosts ns1.unsigned.test
[ 1103.356127] testsuite-75.sh[443]: + getent -s resolve hosts ns1.unsigned.test
[ 1103.356505] testsuite-75.sh[444]: + tee /tmp/tmp.bXg5Uj5Jkk
[ 1103.359591] resolvectl[424]: → Q: ns1.unsigned.test IN AAAA
[ 1103.359591] resolvectl[424]: ← S: success
[ 1103.359850] testsuite-75.sh[444]: 10.0.0.1        ns1.unsigned.test
[ 1103.359939] resolvectl[424]: → Q: ns1.unsigned.test IN A
[ 1103.359939] resolvectl[424]: ← S: success
[ 1103.359939] resolvectl[424]: ← A: ns1.unsigned.test IN A 10.0.0.1
[ 1103.360149] testsuite-75.sh[35]: + grep -qE '^10\.0\.0\.1\s+ns1\.unsigned\.test' /tmp/tmp.bXg5Uj5Jkk
[ 1103.362119] systemd[1]: Starting resmontest.service...
[ 1103.362633] systemd[1]: Started resmontest.service.
[ 1103.363263] testsuite-75.sh[35]: + monitor_check_rr 'ns1.unsigned.test IN A 10.0.0.1'
[ 1103.363263] testsuite-75.sh[35]: + local 'match=ns1.unsigned.test IN A 10.0.0.1'
[ 1103.363377] testsuite-75.sh[35]: + set +o pipefail
[ 1103.363836] testsuite-75.sh[458]: + journalctl -u resmontest.service -f --full
[ 1103.364042] testsuite-75.sh[459]: + grep -m1 'ns1.unsigned.test IN A 10.0.0.1'
...
Trying to halt container. Send SIGTERM again to trigger immediate termination.
Container TEST-75 terminated by signal KILL.
```
 2022-12-08 09:05:14 +09:00
Space Meyer ff868eaade journald: prevent segfault on empty attr/current 
getpidcon() might set con to NULL, even when it returned a 0 return
code[0]. The subsequent strlen(con) will then cause a segfault.

Alternatively the behaviour could also be changed in getpidcon. I
don't know whether the libselinux folks are comitted to the current
behaviour, but the getpidcon man page doesn't really make it obvious
this case could happen.

[0] https://github.com/SELinuxProject/selinux/blob/fb7f35495fbad468d6efa76c5fed727659903038/libselinux/src/procattr.c#L155-L158
 2022-12-08 01:00:25 +01:00
msizanoen1 3d19e122cf core/unit: allow overriding an ongoing freeze operation 
Sometimes a freeze operation can hang due to the presence of kernel
threads inside the unit cgroup (e.g. QEMU-KVM). This ensures that the
ThawUnit operation invoked by systemd-sleep at wakeup always thaws the
unit.
 2022-12-08 00:54:53 +01:00
msizanoen1 a14137d90e core/cgroup: thaw slice of unit when thawing unit 
This ensures starting a new unit under a frozen slice work as expected.
 2022-12-08 00:54:53 +01:00
msizanoen1 fcb0878f75 core/slice: skip member units without realized cgroup during freeze or thaw 
This ensures that services with `RemainAfterExit` but without any
process running won't cause failure during freeze.
 2022-12-08 00:54:53 +01:00
msizanoen1 efa736d383 sleep: always thaw user.slice even if freezing failed 
`FreezeUnit` can fail even when some units did got frozen, causing some
user units to be frozen. A possible symptom is `user@.service` being
frozen while still being able to log in over SSH.
 2022-12-08 00:54:53 +01:00
Luca Boccassi 2d18605ca8 Merge pull request #25632 from keszybz/chroot-fix 
Add trivial check for preset operation in chroot
 2022-12-07 20:51:47 +01:00
Luca Boccassi a101d7849d Merge pull request #25465 from DaanDeMeyer/repart-workspace 
repart: Cleanup created files on failure
 2022-12-07 20:45:23 +01:00
Jelle van der Waa ff4d26dff4 hostnamed: expose FirmwareDate dbus property 
Expose /sys/class/dmi/id/bios_date as dbus property in hostnamed.
 2022-12-07 20:35:56 +01:00
Jelle van der Waa f233bbd607 hostnamed: expose FirmwareVendor as dbus property 
Expose /sys/class/dmi/id/bios_vendor as dbus property in hostnamed.
 2022-12-07 20:34:30 +01:00
Lennart Poettering 0305cf6e9d dissect: add simple --discover command 2022-12-07 17:57:22 +01:00