SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
57,095 Commits 2 Branches 1 Tag
58270534bf5da170ad75b5b41244cd7e761cf660
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Ronny Chevalier 16eefcafed env-util: fix memory leak (#5962) 
If cunescape succeeds, but the assignment is not valid, uce is not freed.
 2017-05-14 10:30:40 -04:00
Ronny Chevalier d5ade2d602 test-conf-parser: add valid and invalid utf8 test for config_parse_path 2017-05-14 13:19:11 +02:00
Ronny Chevalier b4958f42af conf-parser: fix wrong argument given to log_syntax_invalid_utf8 
The condition is on "word", hence we give word instead of rvalue.

An assert would be triggered if !utf8_is_valid(word) is true and
rvalue == NULL, since log_syntax_invalid_utf8 calls utf8_escape_invalid
which calls assert(str).

A test case has been added to test with valid and invalid utf8.
 2017-05-14 13:19:11 +02:00
Ronny Chevalier 80d8b5bc1f Merge pull request #4889 from evverx/fix-test-fs-util-memleak 
test-fs-util: fix memleak
 2016-12-14 11:34:48 +01:00
Ronny Chevalier 9bda42660d Merge pull request #4578 from evverx/no-hostname-memleak 
journalctl: fix memleak
 2016-11-05 15:23:31 +01:00
Ronny Chevalier a3810a08d5 Merge pull request #4579 from evverx/acl-memleak 
acl-util: fix memleak
 2016-11-05 14:22:59 +01:00
Ronny Chevalier baab47d7b9 Merge pull request #4001 from clintonroy/master 
systemctl: kill all units specified on the command line, not just the…
 2016-08-20 11:42:24 +02:00
Ronny Chevalier 3f94fa378e Merge pull request #3992 from poettering/hostname-fix2 
some hostname fixes, triggered by #3979
 2016-08-19 16:46:49 +02:00
Ronny Chevalier 71156dc854 Merge pull request #3960 from keszybz/efi-option-description 
build-sys: clarify that --disable-efi is about sd-boot and bootctl
 2016-08-16 21:22:50 +02:00
Ronny Chevalier 96533edceb Merge pull request #3902 from poettering/parse-nice 
util-lib: unify parsing of nice level values
 2016-08-05 13:35:52 +02:00
Ronny Chevalier 48a97bb4dc Merge pull request #3583 from poettering/restrict-realtime 
add new RestrictRealtime= option to services (and other fixes)
 2016-06-23 13:11:58 +01:00
Ronny Chevalier 2bb6c19f52 Merge pull request #3581 from dobyrch/master 
systemctl:  Add missing "/" to files created by 'edit --runtime'
 2016-06-23 10:15:40 +01:00
Ronny Chevalier fbd9ec188a Merge pull request #3564 from evverx/valgrind-tests-fixes 
tests: fix memory leak, don't run test_get_process_cmdline_harder under valgrind
 2016-06-20 08:41:06 +01:00
Ronny Chevalier 1f7a9e8ee7 Merge pull request #3389 from lucab/to-upstream/man-typos 
man: fix recurring typo
 2016-05-30 12:57:38 +01:00
Ronny Chevalier 6c006ed487 Merge pull request #3011 from evverx/dont-silently-skip-test-namespace 
tests: don't silently skip `test-namespace`
 2016-04-11 13:51:51 +01:00
Ronny Chevalier 34f5ff465f test-execute: fix execution of AmbientCapabilities tests 
Wrong tests were executed
 2016-03-21 18:48:12 +01:00
Ronny Chevalier ed0b16e279 Merge pull request #2828 from mineo/run-help 
run: Improve the help message about timer options and existing units
 2016-03-12 15:56:54 +01:00
Ronny Chevalier ef03147173 Merge pull request #2803 from 0xAX/lacess-tree-wide 
firstboot: use laccess macro instead of facessat()
 2016-03-06 21:20:49 +01:00
Ronny Chevalier 0b8505b7c9 systemctl: improve error message when starting a unit failed 
Fixes #2798
 2016-03-05 12:47:21 +01:00
Ronny Chevalier 31b5d98981 test-util: remove now unused includes 2016-03-03 19:04:07 +01:00
Ronny Chevalier ac229ed890 tests: move xattr-util related tests to test-xattr-util.c 2016-03-03 19:04:07 +01:00
Ronny Chevalier 6a4f4a0fa0 tests: move glob-util related tests to test-glob-util.c 2016-03-03 19:04:07 +01:00
Ronny Chevalier ac933e8ec4 tests: move io-util related tests to test-io-util 2016-03-03 19:04:06 +01:00
Ronny Chevalier d376cbb7b0 tests: move proc-cmdline related tests to test-proc-cmdline.c 2016-03-03 19:04:06 +01:00
Ronny Chevalier 09c303ce5b tests: move fstab-util related tests to test-fstab-util.c 2016-03-03 19:04:06 +01:00
Ronny Chevalier c270684afd tests: move fs-util related tests to test-fs-util.c 2016-03-03 19:04:06 +01:00
Ronny Chevalier f55211dbce tests: move conf-parser related tests to test-conf-parser.c 2016-03-03 19:04:06 +01:00
Ronny Chevalier 0999c8ade8 tests: move fd-util related tests to test-fd-util.c 2016-03-03 19:04:06 +01:00
Ronny Chevalier d5b29bb5d9 tests: move user-util related tests to test-user-util.c 2016-03-03 19:04:06 +01:00
Ronny Chevalier 6329266386 tests: move path-util related tests to test-path-util.c 2016-03-03 19:04:06 +01:00
Ronny Chevalier 897891f02e tests: move fileio related tests to test-fileio.c 2016-03-03 19:04:06 +01:00
Ronny Chevalier f4c13ad76f tests: move stat-util related tests to test-stat-util.c 2016-03-03 19:04:06 +01:00
Ronny Chevalier ede4edd31e tests: move signal-util related tests to test-signal-util.c 2016-03-03 18:46:58 +01:00
Ronny Chevalier 7ba365a9b2 tests: move cpu-set-util related tests to test-cpu-set-util.c 2016-03-03 18:46:58 +01:00
Ronny Chevalier cd3510707a tests: move web-util related tests to test-web-util.c 2016-03-03 18:46:58 +01:00
Ronny Chevalier b66de1f9d4 tests: move alloc related tests to test-alloc-util.c 2016-03-03 18:46:58 +01:00
Ronny Chevalier 45e0b1f68c tests: move escape related tests to test-escape.c 2016-03-03 18:46:58 +01:00
Ronny Chevalier ebde5cb261 tests: move strv related tests to test-strv.c 2016-03-03 18:46:58 +01:00
Ronny Chevalier 6571a64ec9 tests: move string related tests to test-string-util.c 2016-03-03 18:46:58 +01:00
Ronny Chevalier 134714368e tests: move hexdecoct tests to test-hexdecoct.c 2016-03-03 18:46:58 +01:00
Ronny Chevalier 043717f9d3 systemctl: add missing OOM check 2016-03-03 18:16:31 +01:00
Ronny Chevalier 5f18271ec1 systemctl: rm empty dropin dirs after cancelled edit 
Fixes #2734
 2016-03-02 22:06:47 +01:00
Ronny Chevalier 3113d885fe Merge pull request #2764 from benjarobin/fix-stdio-bridge 
stdio-bridge: Correctly propagate error
 2016-02-29 12:23:55 +01:00
Ronny Chevalier 50f130c286 test-execute: add nfsnobody alternative as a nobody user 2016-02-28 15:00:18 +01:00
Ronny Chevalier 19c0b0b9a5 core: set NoNewPrivileges for seccomp if we don't have CAP_SYS_ADMIN 
The manpage of seccomp specify that using seccomp with
SECCOMP_SET_MODE_FILTER will return EACCES if the caller do not have
CAP_SYS_ADMIN set, or if the no_new_privileges bit is not set. Hence,
without NoNewPrivilege set, it is impossible to use a SystemCall*
directive with a User directive set in system mode.

Now, NoNewPrivileges is set if we are in user mode, or if we are in
system mode and we don't have CAP_SYS_ADMIN, and SystemCall*
directives are used.
 2016-02-28 14:44:26 +01:00
Ronny Chevalier 3a89c3a0fc Merge pull request #2058 from phomes/unused-variable2 
tree-wide: remove unused variables
 2015-11-29 15:43:02 +01:00
Ronny Chevalier f9a1dafb93 Merge pull request #1795 from msekletar/networkd-forward 
networkd: fix option name in log message
 2015-11-06 18:14:24 +01:00
Ronny Chevalier c719f96db5 Merge pull request #1800 from evverx/fix-test-execute 
test-execute: don't use /usr/bin/uname. use sh and PATH
 2015-11-06 16:59:05 +01:00
Ronny Chevalier ffbc002ca4 Merge pull request #1780 from evverx/fix-install-dbus 
test-functions: fix dbus-1 installation
 2015-11-04 20:07:23 +01:00
Ronny Chevalier 3342582deb Merge pull request #1757 from phomes/minor-fixes 
Minor fixes
 2015-11-02 23:27:49 +01:00
Ronny Chevalier 534e8f89d6 Merge pull request #1734 from evverx/overwrite-sysemd-unit-path 
core: set_unit_path overwrites SYSTEMD_UNIT_PATH
 2015-10-31 17:22:20 +01:00
Ronny Chevalier aa8e00da54 test-path: move all related test files to a specific directory 
To avoid polluting test/
 2015-10-31 15:07:19 +01:00
Ronny Chevalier ac40081621 test-execute: move all files related to a specific directory 
To avoid polluting test/
 2015-10-31 15:07:19 +01:00
Ronny Chevalier 7d0f09a932 build-sys: add missing test files to EXTRA_DIST 2015-10-31 15:07:19 +01:00
Ronny Chevalier a622675862 test-execute: add tests for IOSchedulingClass 2015-10-31 15:07:19 +01:00
Ronny Chevalier c388dfea5a test-execute: add tests for OOMScoreAdjust 2015-10-31 15:07:19 +01:00
Ronny Chevalier 03bd70dd01 test-execute: add test for EnvironmentFile 2015-10-31 15:07:19 +01:00
Ronny Chevalier 63447f1153 test-execute: add test for PrivateNetwork 2015-10-31 15:07:19 +01:00
Ronny Chevalier ff4ca461ed test: add tests to ensure that the capabilities are properly set 2015-10-29 17:14:18 +01:00
Ronny Chevalier db27190d54 Merge pull request #1713 from evverx/test-cap-bounding-set-merging 
Another fix of the CapabilityBoundingSet parsing
 2015-10-29 13:44:23 +01:00
Ronny Chevalier cc7fa4fb4a test-execute: check if nobody exists before running some tests 2015-10-28 11:51:37 +01:00
Ronny Chevalier f739078599 Merge pull request #1671 from keszybz/zsh-journalctl-identifier 
zsh-completion: journalctl --identifier
 2015-10-25 17:19:30 +01:00
Ronny Chevalier bf3ee9cdc9 Merge pull request #1622 from phomes/unused-variable 
dbus-execute: remove unused variable
 2015-10-20 19:48:27 +02:00
Ronny Chevalier 6a0dacb7aa Merge pull request #1582 from evverx/dump-runtime-dir-mode 
core: dump RuntimeDirectories and RuntimeDirectoryMode too
 2015-10-16 21:33:17 +02:00
Ronny Chevalier 5bc7452b32 core: fix group ownership when Group is set 
When Group is set in the unit, the runtime directories are owned by
this group and not the default group of the user (same for cgroup paths
and standard outputs)

Fix #1231
 2015-09-21 18:14:44 +02:00
Ronny Chevalier cc3ddc851f test-execute: add tests for RuntimeDirectory 2015-09-21 18:14:44 +02:00
Ronny Chevalier 5625be76c7 test-ipv4ll: use unsigned instead of an array for a seed 
ipv4ll use an unsigned instead of an uint8_t array. Hence, use an
unsigned seed instead of declaring an array and then dereferencing it
later.
 2015-09-21 16:52:52 +02:00
Ronny Chevalier 56065db421 sd-ipv4ll: do not assert_return when seed == 0 
Now that seed is an unsigned and not an array, we do not need to assert
on it.
 2015-09-21 16:52:52 +02:00
Ronny Chevalier ab5838fce7 Merge pull request #968 from alkino/master 
zsh completion: update busctl
 2015-08-15 14:21:42 +02:00
Ronny Chevalier cf4d75ccf9 Merge pull request #297 from ssahani/net 
networkd: vlan improve logging
 2015-06-19 10:24:13 +02:00
Ronny Chevalier c655146496 NEWS: fix typo 2015-06-18 16:23:28 +02:00
Ronny Chevalier c59d3e8d37 signal-util: fix incorrect argument of va_start 
The last argument of the function before the vargs is "old" not "how".

warning: second parameter of ‘va_start’ not last named argument
 2015-06-16 11:41:59 +02:00
Ronny Chevalier b9460fdc8b login: fix potential null pointer dereference 
Fix CID 1304686: Dereference after null check (FORWARD_NULL)

However, this commit does not fix any bug in logind. It helps to keep
the elect_display_compare() function generic.
 2015-06-15 10:22:32 +02:00
Ronny Chevalier eb59b60941 Merge pull request #179 from l10n-tw/master 
po: fix zh_TW mailing list.
 2015-06-12 15:30:54 +02:00
Ronny Chevalier cca91b41d9 Merge pull request #164 from l10n-tw/master 
Add zh_TW translation.
 2015-06-12 15:02:00 +02:00
Ronny Chevalier 98d7580046 conf-parser: parsing error logs should show a type not a vartype 
Instead of this:
[filename:1] Failed to parse nsec_t value, ignoring: garbage

we show this:
[filename:1] Failed to parse nsec value, ignoring: garbage
 2015-05-30 12:24:16 +02:00
Ronny Chevalier 732b7f39a2 networkctl: fix uninitialized variable 
We ignore the return value of sd_device_get_devtype, then devtype could
be uninitialized when used with streq_ptr. So we need to initialize it
first.
 2015-05-30 11:19:36 +02:00
Ronny Chevalier 8f42ccd24b README: fix typo 2015-05-30 11:19:35 +02:00
Ronny Chevalier da090dfd0b zsh-completion: update bootctl 2015-05-30 11:19:35 +02:00
Ronny Chevalier 0805e9a9c8 test-fdset: add more tests 
add tests for the following functions:
- fdset_new_array
- fdset_steal_first
- fdset_isempty
 2015-05-30 11:19:35 +02:00
Ronny Chevalier 0763adbed5 tests: add test-conf-parser 2015-05-30 11:19:35 +02:00
Ronny Chevalier ca909b8469 test: test-path and test-execute only need units in test/ 2015-04-21 19:27:59 +02:00
Ronny Chevalier 3c8000956a shared: move replace_env* from util to env-util 2015-04-11 00:34:03 +02:00
Ronny Chevalier 288a74cce5 shared: add terminal-util.[ch] 2015-04-11 00:34:02 +02:00
Ronny Chevalier 3df3e884ae shared: add random-util.[ch] 2015-04-11 00:11:13 +02:00
Ronny Chevalier 0b452006de shared: add process-util.[ch] 2015-04-10 23:54:49 +02:00
Ronny Chevalier 6482f6269c shared: add formats-util.h 2015-04-10 23:54:48 +02:00
Ronny Chevalier 756c09e672 core: set_put never returns -EEXIST 
When the value is already there it returns 0.

Also add a test to ensure this
 2015-04-10 17:13:15 +02:00
Ronny Chevalier 0d67448869 shared: fix memleak 
path was used for 2 purposes but it was not freed before being reused.
 2015-04-10 15:44:02 +02:00
Ronny Chevalier 3e348b8a6a test-journal-flush: fix memleak 2015-04-09 18:47:52 +02:00
Ronny Chevalier cd977dca10 util: cunescape - fix memleak in error path 2015-04-09 18:47:52 +02:00
Ronny Chevalier 39505e3c3b remove duplicated includes 2015-04-08 02:42:50 +02:00
Ronny Chevalier 3906ab4adf timedatectl: trim --help output to 80 chars 2015-04-08 02:42:50 +02:00
Ronny Chevalier d67b1f525f zsh-completion: update hostnamectl 2015-04-08 02:42:50 +02:00
Ronny Chevalier b178d279d9 zsh-completion: add missing -M completion for journalctl 2015-04-08 02:42:50 +02:00
Ronny Chevalier 8470025541 zsh-completion: update loginctl 2015-04-08 02:42:50 +02:00
Ronny Chevalier 07916bea07 test-socket-util: add test for in_addr_to_string 2015-04-08 02:42:50 +02:00
Ronny Chevalier 0c0cdb06c1 tests: use assert_se instead of assert 
Otherwise they can be optimized away with -DNDEBUG
 2015-01-22 23:10:56 +01:00
Ronny Chevalier 9b0374e954 man: fix typos 2015-01-22 22:44:07 +01:00
Ronny Chevalier 78a8e158da test-path: do not skip tests if we are not root 
We can properly run the tests without being root
 2015-01-15 00:57:44 +01:00