Commit Graph
100 Commits
Author SHA1 Message Date
Thomas Hindoe Paaboel Andersen 1e190dfd5b Revert "sysctl.d: request ECN on both in and outgoing connections"
Turning on ECN still causes slow or broken network on linux. Our tcp
is not yet ready for wide spread use of ECN.

This reverts commit 919472741dba6ad0a3f6c2b76d390a02d0e2fdc3.
2018-08-20 09:37:41 +02:00
Thomas H. P. Andersen 6f130e85c7 sysctl.d: request ECN on both in and outgoing connections (#9143)
To further avoid bufferbloat Explicit Congestion Notification (ECN)
should be enabled for both in and outgoing connections. The kernel
default is to enable it when requested for incoming connections, but
not to request it on outgoing connections. This patch enables it for
both.

A long time ago enabling these was causing problems, but these issues
have since been dealt with.

Fixes #9087.
2018-05-31 13:30:10 +02:00
Thomas Hindoe Paaboel Andersen caf2a2d8e6 NEWS: typo fix 2018-01-28 00:05:27 +01:00
Thomas H. P. Andersen 38d9338588 NEWS: typo fixes (#6276) 2017-07-03 17:35:05 -04:00
Thomas Hindoe Paaboel Andersen 6eeec374c1 tree-wide: remove unused variables 2017-04-28 23:56:44 +02:00
Thomas Hindoe Paaboel Andersen 85df3c6037 networkd: remove duplicated include 2017-04-28 23:56:44 +02:00
Thomas Hindoe Paaboel Andersen b3c908b4a2 shared: assert the source for memcpy 2017-04-28 23:56:44 +02:00
Thomas H. P. Andersen 557e36934d cgtop: use PRIu64 to print uint64_t (#5544)
Commit 59f448cf replaced usage of off_t with uint64_t. Change the
format string to use PRIu64 to match it.
2017-03-07 07:47:18 +01:00
Thomas Hindoe Paaboel Andersen 128e6266ad hwdb: quirks for accelerometers in HP laptops
This patch adds quirks for the two laptops I could test on
(8540w and 8560w). The accelerometer is configured in the
kernel to report values according to the base of the laptop.
We want the values according to the screen instead.

It is likely (but untested) to match all HP laptops with the
lis3lv02d accelerometer on this list:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/hp_accel.c#n207
2017-03-03 21:35:57 +01:00
Thomas Hindoe Paaboel Andersen 3e021232da rules: allow quirks for platform input accelerometers 2017-03-03 21:23:39 +01:00
Thomas H. P. Andersen 3b31c46634 NEWS: fix typo (#5453) 2017-02-25 09:19:26 -05:00
Thomas H. P. Andersen 0f5a443e8c coredump: fix assign in while loop (#5417)
From: #5393
2017-02-22 00:14:54 +01:00
Thomas H. P. Andersen fcd574d4c1 path-lookup: use correct cleanup function for strv (#5007) 2017-01-03 21:02:39 +01:00
Thomas H. P. Andersen 323de07d44 machined: remove unused variable (#4993) 2016-12-29 11:15:08 +01:00
Thomas Hindoe Paaboel Andersen 8fb242abc9 core: remove unused variable 2016-12-06 00:09:50 +01:00
Thomas Hindoe Paaboel Andersen 11754a3486 udev: remove duplicate flag
One SA_RESTART is enough. Fall out from
e28c7cd066
2016-12-06 00:09:43 +01:00
Thomas H. P. Andersen 342d3ac165 hwdb: fix error check of wrong variable (#4499)
We updated 'fn' but checked 'v' instead.

From 698c5a17

Spotted with PVS
2016-10-26 21:22:26 -04:00
Thomas H. P. Andersen 6328c51a5d gitignore: add test-seccomp (#4498) 2016-10-26 19:40:25 -04:00
Thomas Hindoe Paaboel Andersen b5331acc96 journal: remove unused variable 2016-10-22 16:00:11 +02:00
Thomas H. P. Andersen 5c4624e082 nspawn: remove unused variable (#4369) 2016-10-14 00:30:28 +03:00
Thomas Hindoe Paaboel Andersen 2dd678171e man: typo fixes
A mix of fixes for typos and UK english
2016-10-12 23:02:44 +02:00
Thomas H. P. Andersen f68c9dd5c6 resolve: remove unsed counter (#4349)
It was introduced but never used in 45ec7efb.
2016-10-11 13:51:03 -04:00
Thomas H. P. Andersen 01b0669e9a resolved: initialize variable (#4338)
r was not initialized and would be used if "tcp" was the only option
used for the stub. We should initialize it to 0 to indicate that no
error happened in the udp case.
2016-10-10 20:12:40 -04:00
Thomas H. P. Andersen d4c08299f2 NEWS: typo fixes (#4285) 2016-10-04 20:41:46 +02:00
Thomas H. P. Andersen f8298f7be3 core: remove duplicate includes (#3771) 2016-07-21 10:52:07 +02:00
Thomas Hindoe Paaboel Andersen 12c40d4cc4 resolved: replace bitwise and with logical and 2016-07-18 22:42:13 +02:00
Thomas Hindoe Paaboel Andersen ba19c6e181 treewide: remove unused variables 2016-07-18 22:32:08 +02:00
Thomas Hindoe Paaboel Andersen 65a6195e76 basic: fix whitespace 2016-07-18 22:14:23 +02:00
Thomas Hindoe Paaboel Andersen 82edec5451 network: fix indentation 2016-07-18 22:09:57 +02:00
Thomas H. P. Andersen 188d308203 NEWS: typo fix and american english (#3301) 2016-05-20 15:04:01 +02:00
Thomas H. P. Andersen 977f2beaf2 NEWS: typo fix and american english (#3219) 2016-05-07 17:52:31 -04:00
Thomas Hindoe Paaboel Andersen 3eb8326162 test-networkd-conf: fix memleak 2016-05-05 13:24:03 +02:00
Thomas Hindoe Paaboel Andersen 2679936e68 networkd: fix memleak in config_parse_duid_rawdata 2016-05-05 13:24:03 +02:00
Thomas H. P. Andersen 37818090c9 Trivial network cleanup (#3196)
* gitignore: typo fix for test-networkd-conf

* networkd: fix double include
2016-05-05 11:15:46 +02:00
Thomas H. P. Andersen 0f5e13822d tree-wide: remove unused variables (#3098) 2016-04-22 20:49:07 -04:00
Thomas Hindoe Paaboel Andersen 17a8630621 stdio-bridge: remove dead code 2016-02-26 22:23:38 +01:00
Thomas Hindoe Paaboel Andersen 7f508f2c74 tree-wide: indentation fixes 2016-02-26 22:23:38 +01:00
Thomas Hindoe Paaboel Andersen 404d53a968 networkctl: fix const 2016-02-23 20:40:51 +01:00
Thomas Hindoe Paaboel Andersen 662ea1b14a tree-wide: remove unused variables 2016-02-23 20:40:51 +01:00
Thomas Hindoe Paaboel Andersen 7c9337dae8 basic: mark unused variable as such 2016-02-23 20:40:51 +01:00
Thomas Hindoe Paaboel Andersen 9e4942ed5a core: use correct enum
from e903182e5b
2016-02-11 19:04:54 +01:00
Thomas Hindoe Paaboel Andersen ec76e139d8 resolve: fix compare function for EtcHostItem
From dd0bc0f1
2016-01-26 20:34:21 +01:00
Thomas Hindoe Paaboel Andersen f770083430 resolve-host: add error checking 2015-12-28 00:05:17 +01:00
Thomas Hindoe Paaboel Andersen c03cba007a resolve: remove unused variables 2015-12-28 00:05:17 +01:00
Thomas Hindoe Paaboel Andersen 097a251711 resolve: fix indentation 2015-12-20 16:59:24 +01:00
Thomas Hindoe Paaboel Andersen b78b0b674f resolve: remove unused variable 2015-12-16 19:59:45 +01:00
Thomas Hindoe Paaboel Andersen 111befce55 resolve: fix indendation 2015-12-16 19:59:45 +01:00
Thomas Hindoe Paaboel Andersen 22ebb9e4a9 resolve: remove unused variable 2015-12-06 13:49:33 +01:00
Thomas Hindoe Paaboel Andersen a8fbdf5424 shared: include what we use
The next step of a general cleanup of our includes. This one mostly
adds missing includes but there are a few removals as well.
2015-12-06 13:49:33 +01:00
Thomas Hindoe Paaboel Andersen 93cc7779e0 basic: re-sort includes
My previous patch to only include what we use accidentially placed
the added inlcudes in non-sorted order.
2015-12-01 23:40:17 +01:00
Thomas Hindoe Paaboel Andersen 11c3a36649 basic: include only what we use
This is a cleaned up result of running iwyu but without forward
declarations on src/basic.
2015-11-30 21:51:03 +01:00
Thomas Hindoe Paaboel Andersen ae96c4eb2c tree-wide: remove unused variables 2015-11-29 08:59:40 +01:00
Thomas Hindoe Paaboel Andersen 6617082bc8 resolved: remove unused variable 2015-11-24 17:10:32 +01:00
Thomas Hindoe Paaboel Andersen bf40958019 systemctl: do not return uninitialized r
Regresssed during port to extract_first_word in
5ab22f3321

CID #1338060
2015-11-22 23:11:20 +01:00
Thomas Hindoe Paaboel Andersen 74544b4ead networkd: link - fix reading routes
This regressed during the port to extract_first_word in c598ac76
(v228).

CID #1338083
2015-11-22 18:53:36 +01:00
Thomas Hindoe Paaboel Andersen 71d35b6b55 tree-wide: sort includes in *.h
This is a continuation of the previous include sort patch, which
only sorted for .c files.
2015-11-18 23:09:02 +01:00
Thomas Hindoe Paaboel Andersen 928bc597b7 network: fix indentation 2015-11-18 19:08:44 +01:00
Thomas Hindoe Paaboel Andersen b4bbcaa9c4 tree-wide: group include of libudev.h with sd-* 2015-11-17 07:06:08 +01:00
Thomas Hindoe Paaboel Andersen cf0fbc49e6 tree-wide: sort includes
Sort the includes accoding to the new coding style.
2015-11-16 22:09:36 +01:00
Thomas Hindoe Paaboel Andersen ab5dfda78f tree-wide: add missing includes
Add a few includes that we rely on to be include already.
2015-11-16 22:08:33 +01:00
Thomas Hindoe Paaboel Andersen a2f46e8495 network: dhcp6 - fix mem leak
from 7a695d8e
CID#1338679
2015-11-15 23:10:28 +01:00
Thomas Hindoe Paaboel Andersen 23bfbe7fdb gitignore: add test-install-root 2015-11-15 20:36:22 +01:00
Thomas Hindoe Paaboel Andersen 815bb5bd56 NEWS: typo fixes 2015-11-15 17:30:33 +01:00
Thomas Hindoe Paaboel Andersen d986e364c4 install: don't mix state and type enums
from 0ec0deaa
2015-11-15 14:45:24 +01:00
Thomas Hindoe Paaboel Andersen 6a0f3175dc core: remove unused variable
unused since 7b2313f5
2015-11-07 11:05:58 +01:00
Thomas Hindoe Paaboel Andersen 859fdd1eea sysv-generator: remove duplicate const
I assume this was a typo in c279613f86
2015-11-02 23:18:20 +01:00
Thomas Hindoe Paaboel Andersen f2c624cb8b man: various typos 2015-11-02 23:18:20 +01:00
Thomas Hindoe Paaboel Andersen ce9d6bcf33 path-util: do not return NULL as int
strv_split will only return NULL on oom so we should return -ENOMEM
instead.

Looks like an oversight from the changes in 0f474365
2015-10-26 22:31:37 +01:00
Thomas Hindoe Paaboel Andersen 2bb158c1ce tmpfiles: simplify mountpoint detection
No functional change. Just a simplification. A || (!A && B) is
the same as A || B

Introduced in 78a92a5a23
2015-10-23 22:35:03 +02:00
Thomas Hindoe Paaboel Andersen 9ecc70db1e dbus-execute: remove unused variable
from ceb728cf
2015-10-20 19:39:31 +02:00
Thomas Hindoe Paaboel Andersen b250ea2fd6 tree-wide: remove unused functions 2015-10-19 21:46:01 +02:00
Thomas Hindoe Paaboel Andersen 74165387ee manager: remove unused function 2015-10-13 22:17:26 +02:00
Thomas Hindoe Paaboel Andersen 2366ab3026 shared: remove an unused variable 2015-10-11 19:40:54 +02:00
Thomas Hindoe Paaboel Andersen ac9455efdd rfkill: consistently use = in designator 2015-10-11 19:40:54 +02:00
Thomas Hindoe Paaboel Andersen 19932084d0 sd-bus: va_start should use the last named parameter 2015-09-27 23:11:31 +02:00
Thomas Hindoe Paaboel Andersen 4f76ef0423 man: typo fixes 2015-09-07 20:06:58 +02:00
Thomas Hindoe Paaboel Andersen b8a50a99a6 sd-event: fix call to event_make_signal_data
This looks like a typo from commit 9da4cb2b where it was added.
2015-09-06 22:19:09 +02:00
Thomas Hindoe Paaboel Andersen b3c5bad3d6 tree-wide: fix indentation 2015-09-02 20:46:42 +02:00
Thomas Hindoe Paaboel Andersen 09d2f5b1c9 scope: do not compare a bool return with "<= 0" 2015-09-02 19:58:12 +02:00
Thomas Hindoe Paaboel Andersen ea24343247 hwdb: more mice 2015-09-01 22:02:05 +02:00
Thomas Hindoe Paaboel Andersen 5575c4e603 man: fix typos in systemd-path.xml 2015-09-01 18:31:04 +02:00
Thomas Hindoe Paaboel Andersen 64d6c22905 tree-wide: do not shadow the global var timezone 2015-09-01 18:20:13 +02:00
Thomas Hindoe Paaboel Andersen 0ab8a1b622 networkd: initialize tz to null
We may not set it before checking it for null.
2015-08-30 03:23:07 +02:00
Thomas Hindoe Paaboel Andersen f80bb1f7ea util: make malloc0 ask calloc for one block of size n
... instead of an array of n individual bytes.

Silences a lot of warnings in smatch.
2015-08-30 02:32:33 +02:00
Thomas Hindoe Paaboel Andersen c7c9fd04bd hwdb: update entry for logitech RX 250
I tested a RX 250 and measured 1000 DPI. The spec for the mouse
agrees:
http://www.logitech.com/en-gb/product/rx250-optical-mouse-business

This is an optical mouse so it is extra sensitive to what kind of
surface it is tested on.
2015-08-28 23:47:48 +02:00
Thomas Hindoe Paaboel Andersen 23c4147f2b hwdb: add a few more mice 2015-08-28 23:47:44 +02:00
Thomas Hindoe Paaboel Andersen 21e5a0bea0 test-util: fix a memleak 2015-08-25 23:52:18 +02:00
Thomas Hindoe Paaboel Andersen c615b4ba9f machinectl: remove unused variable 2015-08-25 21:15:54 +02:00
Thomas Hindoe Paaboel Andersen 2307f37e46 execute: make the invalid entry of the enum -1
Set _EXEC_UTMP_MODE_INVALID to -1. This matches the return value from
string_table_lookup.
2015-08-25 21:15:54 +02:00
Thomas Hindoe Paaboel Andersen 62f176068c remove unused variables 2015-08-21 22:19:10 +02:00
Thomas Hindoe Paaboel Andersen b2b46f91db journal: remove error check that never happens
remove_directory will always return 0 so this can never happen.
Besides that, d->path and d are freed so we would end up with
a null pointer dereference anyway.
2015-08-18 00:11:16 +02:00
Thomas Hindoe Paaboel Andersen 88231eb62c logind: actually fail on OOM
Since dacd6cee76 the two OOM's are
ignored as the value of r will be overwritten and we only log in
the fail section anyway.

This patch jumps to fail on OOM.

Note that this is different behavior compared to both the current
code and previous to dacd6cee76. Before
that commit we would log that saving the inhibit data failed, but
still write the file, though without the WHO/WHY section.

CID# 1313545
2015-08-13 23:53:49 +02:00
Thomas Hindoe Paaboel Andersen 6b829dddc6 hwdb: add DPI for a few more mice 2015-08-12 22:29:28 +02:00
Thomas Hindoe Paaboel Andersen 756775814c tree-wide: do not return error codes as bool 2015-08-06 00:49:45 +02:00
Thomas Hindoe Paaboel Andersen 7d6884b65e tree-wide: fix indentation 2015-08-06 00:44:19 +02:00
Thomas Hindoe Paaboel Andersen 1ae2285324 gpt-auto-generator: remove unused variable 2015-08-04 22:36:21 +02:00
Thomas Hindoe Paaboel Andersen 75440a51b2 hwdb: add Logitech LX8 DPI and wheel click settings 2015-08-04 22:15:30 +02:00
Thomas Hindoe Paaboel Andersen d78dfff261 hwdb: add HP USB 1000dpi Laser Mouse 2015-07-28 20:10:59 +02:00
Thomas Hindoe Paaboel Andersen dd2b607b7d man: typo fixes 2015-07-25 23:15:51 +02:00
Thomas Hindoe Paaboel Andersen 7bea001ea4 ata_id: remove unused union member
The last use of octa was removed in 01f61d331b
2015-07-25 00:14:13 +02:00