Thomas Hindoe Paaboel Andersen
733dbdc534
efivars: fix build for non-efi
2015-04-10 23:00:07 +02:00
Tom Gundersen
2e036c4eae
shared: boot-timestamps - remove ifdef
...
No need to ifdef out efi code as the functions are always defined.
2015-04-10 19:55:49 +02:00
Tom Gundersen
b28ce7c6db
shared: efivars - fix compile on non-EFI systems
...
systemctl and logind were unconditionally using functions that were not compiled
on non-EFI systems. Add stubs returning -EOPNOTSUPP to fix compile again.
2015-04-10 19:55:49 +02:00
Tom Gundersen
9df49b3358
shared: efivars - is_efi_*() returns bool instead of int
...
There was a bug where is_efi_*() could return a negative error value, which would be treated as 'true',
just make this a bool in the helper library to avoid the problem.
2015-04-10 19:55:49 +02:00
Lennart Poettering
3dc055541c
Revert "sd-dhcp-client: fix strict aliasing issue"
...
This reverts commit 6ec8e7c763 .
This doesn't fix any issues, just makes the code harder to read.
2015-04-10 19:04:43 +02:00
Lennart Poettering
53bac4e0e3
sd-event: simplify sd_event_run()
2015-04-10 18:45:39 +02:00
Lennart Poettering
5c5ccf12b6
tmpfiles: add specifier expansion for L and C lines, too
2015-04-10 18:07:04 +02:00
Lennart Poettering
b1b5922e2f
update TODO
2015-04-10 17:36:07 +02:00
Michal Sekletar
d5cad22109
bus-util: be more verbose if dbus job fails
...
Users might have hard time figuring out why exactly their systemctl request
failed. If dbus job fails try to figure out more details about failure by
examining Result property of the service.
https://bugzilla.redhat.com/show_bug.cgi?id=1016680
2015-04-10 17:36:07 +02:00
Ronny Chevalier
756c09e672
core: set_put never returns -EEXIST
...
When the value is already there it returns 0.
Also add a test to ensure this
2015-04-10 17:13:15 +02:00
Lennart Poettering
17493fa5d1
tmpfiles: enforce ordering when executing lines
...
Always create files first, and then adjust their ACLs, xattrs, file
attributes, never the opposite. Previously the order was not
deterministic, thus possibly first adjusting ACLs/xattrs/file
attributes before actually creating the items.
2015-04-10 16:23:47 +02:00
Lennart Poettering
90937fe3d3
tmpfiles: eat up empty columns
2015-04-10 16:23:46 +02:00
Lennart Poettering
bd550f78eb
tmpfiles: substitute % specifiers in arguments for writing files and xattrs
2015-04-10 16:23:46 +02:00
Lennart Poettering
c82500c6fb
tmpfiles: warn if we get an argument on lines that don't take any
2015-04-10 16:23:46 +02:00
Lennart Poettering
3ea40b7810
tmpfiles: mostly revert 71044f609b
...
Add a comment why returning a positive error is OK and intended in this
case.
(It's still a nasty hack to do this though!)
2015-04-10 16:23:46 +02:00
Lennart Poettering
f0bc504794
device-nodes: minor simplifications
2015-04-10 16:23:46 +02:00
Lennart Poettering
2ff7b0a542
util: unify how we parse mode_t strings
2015-04-10 16:23:46 +02:00
Lennart Poettering
6dd67163b8
util: remove normalize_env_assignment(), it's unused
2015-04-10 16:23:46 +02:00
Ronny Chevalier
0d67448869
shared: fix memleak
...
path was used for 2 purposes but it was not freed before being reused.
2015-04-10 15:44:02 +02:00
Lennart Poettering
e1eaca26cb
util: mark unquote() static, so that new code doesn't use this anymore
2015-04-10 12:16:54 +02:00
Lennart Poettering
8ebac1f9a6
util: fix unicode decoding in unquote_first_word()
2015-04-10 11:56:04 +02:00
Lennart Poettering
f3ee629711
util: when unescaping C escape sequences support C++11 \u and \U unicode literals
...
We simply recode them in utf8.
2015-04-10 11:28:34 +02:00
Thomas Hindoe Paaboel Andersen
96406c1a27
util: fix a typo in comment
2015-04-09 23:58:28 +02:00
David Herrmann
7757517220
terminal/page: drop unneeded DISABLE_WARNING_*
...
The macros in shared/macro.h have been updated to no longer use fixed
variable names. This will silence any shadowing-warnings, so drop the
DISABLE_WARNING_* annotations.
2015-04-09 22:59:59 +02:00
David Herrmann
43ef760376
bus: simplify bus_message_read_strv_extend()
...
Avoid unbound for(;;) loop and use the established coding-style:
while ((r = sd_bus_message_read*(...)) > 0) {
}
if (r < 0)
return r;
This is much easier to read and used all over the code base.
2015-04-09 22:59:59 +02:00
David Herrmann
0704ea57b7
bus: use free_and_strdup()
...
Save some LOCs by replacing strdup()+error-handling+free+assign with
free_and_strdup().
2015-04-09 22:59:59 +02:00
David Herrmann
0a790ab540
terminal/idev: fix NULL terminator for bus-property mapping
...
We require a NULL entry as sentinal in bus_properties_map. Fix this!
2015-04-09 22:59:58 +02:00
Ronny Chevalier
3e348b8a6a
test-journal-flush: fix memleak
2015-04-09 18:47:52 +02:00
Ronny Chevalier
cd977dca10
util: cunescape - fix memleak in error path
2015-04-09 18:47:52 +02:00
Lennart Poettering
019c7fba75
util: add shell_maybe_quote() call for preparing a string for shell cmdline inclusion
...
If necessary the passed string is enclosed in "", and all special
characters escapes.
This also ports over usage in bus-util.c and job.c to use this, instead
of a incorrect local implementation that forgets to properly escape.
2015-04-09 18:32:21 +02:00
Lennart Poettering
ab51b943d4
vconsole: some modernizations, indentation fixes
2015-04-09 13:13:07 +02:00
Lennart Poettering
71044f609b
tmpfiles: properly return error code from path_set_acl()
2015-04-09 13:13:07 +02:00
Lennart Poettering
34f6453603
tmpfiles: add file attribute calls to list of glob needing commands
2015-04-09 13:13:07 +02:00
Lennart Poettering
8aa203819f
update TODO
2015-04-09 13:13:07 +02:00
Lennart Poettering
aecb6fcb03
vconsole: stick to kernel-style function error handling
...
This undoes part of 8931278c8a .
We really should stick to kernel-style "int" return values from
functions, and not covnert success into boolean returns.
2015-04-09 13:13:07 +02:00
Blaž Tomažič
729bc933be
hwdb: mouse DPI data, Roccat Lua (ROC-11-310)
...
https://bugs.freedesktop.org/show_bug.cgi?id=89743
2015-04-09 16:55:27 +10:00
Thomas Hindoe Paaboel Andersen
8489a3b769
networkd: do not assign the variable twice
2015-04-09 00:05:58 +02:00
Lennart Poettering
aeb1e2c5b0
update TODO
2015-04-08 22:39:40 +02:00
Lennart Poettering
88ec4dfa28
tmpfiles: rework file attribute code
...
- Stick to one type for the flags field: unsigned. This appears to be
what the kernel uses, and there's no point in using something else.
- compress the flags array by avoiding sparse entries
- extend some error messages to not use abbreviated words
- avoid TTOCTTOU issues by invoking fstat() after open() when applying
file flags
- add explanation why we need to check the file type with fstat().
- don't needlessly abbreviate "attribute" as "attrib", in particually as
"chattr" abbreviates it as "attr" rather than "attrib".
2015-04-08 22:35:52 +02:00
Lennart Poettering
1ed8f8c16d
util: merge change_attr_fd() and chattr_fd()
2015-04-08 20:47:35 +02:00
Lennart Poettering
171181bcd6
fstab-generator: don't continue on OOM
2015-04-08 20:27:11 +02:00
Lennart Poettering
481b3f9e99
timesyncd: print an INFO log message when we successfully reached a time server
2015-04-08 20:14:04 +02:00
Lennart Poettering
b90930c73b
man: avoid confusion regarding "time synchronization state"
...
Also, update example in the timedatectl man page to match the actual
timedatectl output.
2015-04-08 18:34:08 +02:00
Jan Janssen
a4921cf4e2
systemctl: Use logind for --firmware-setup if possible
2015-04-08 18:22:16 +02:00
Zbigniew Jędrzejewski-Szmek
a40e26f392
Indentation
2015-04-08 11:28:45 -04:00
Zbigniew Jędrzejewski-Szmek
d6a12e7ca3
man: remove 'fs' from 'rootfsflags'
...
rootfsflags does not appear anywhere else.
2015-04-08 11:28:45 -04:00
Zbigniew Jędrzejewski-Szmek
50b03c8ea1
core/automount: beef up error message
...
This should not happen... but when it does more information is nice.
2015-04-08 11:28:45 -04:00
Zbigniew Jędrzejewski-Szmek
7b742b3130
shell-completion: systemctl switch-root verb
...
The completion is rudimentary (all files). I think this is OK since
this is used so rarely. But not having it proposed at all is annoying.
2015-04-08 11:28:45 -04:00
Lennart Poettering
b18d23d7ac
update TODO
2015-04-08 17:24:23 +02:00
Lennart Poettering
822db23cfa
resolved: maintain order when writing resolv.conf entries
...
http://lists.freedesktop.org/archives/systemd-devel/2015-March/029850.html
2015-04-08 17:23:27 +02:00